chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc - Issue 1579863003: Convert Pass()→std::move() for Mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/chrome_browser_policy_connector.cc ('k') | chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

index a6ad5f1cd094523872303becb63ca84874f87554..ab34959befaac01f1fd4abaceb976be88c5356c0 100644

--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

@@ -6,6 +6,8 @@

#include <stddef.h>

+#include <utility>

#include "base/files/file_util.h"

#include "base/mac/bundle_locations.h"

#include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h"

@@ -33,7 +35,7 @@ void VerifyBinaryIntegrityHelper(IncidentReceiver* incident_receiver,

incident(new ClientIncidentReport_IncidentData_BinaryIntegrityIncident());

if (!evaluator.PerformEvaluation(incident.get())) {

incident_receiver->AddIncidentForProcess(

- make_scoped_ptr(new BinaryIntegrityIncident(incident.Pass())));

+ make_scoped_ptr(new BinaryIntegrityIncident(std::move(incident))));

} else {

// Clear past incidents involving this bundle if the signature is

// now valid.