Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/password_manager/password_store_proxy_mac.cc

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_proxy_mac.h" 5 #include "chrome/browser/password_manager/password_store_proxy_mac.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility>
8 9
9 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
10 #include "chrome/browser/password_manager/password_store_mac.h" 11 #include "chrome/browser/password_manager/password_store_mac.h"
11 #include "chrome/browser/password_manager/simple_password_store_mac.h" 12 #include "chrome/browser/password_manager/simple_password_store_mac.h"
12 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
13 #include "crypto/apple_keychain.h" 14 #include "crypto/apple_keychain.h"
14 15
15 using password_manager::MigrationStatus; 16 using password_manager::MigrationStatus;
16 using password_manager::PasswordStoreChangeList; 17 using password_manager::PasswordStoreChangeList;
17 18
18 PasswordStoreProxyMac::PasswordStoreProxyMac( 19 PasswordStoreProxyMac::PasswordStoreProxyMac(
19 scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner, 20 scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
20 scoped_ptr<crypto::AppleKeychain> keychain, 21 scoped_ptr<crypto::AppleKeychain> keychain,
21 scoped_ptr<password_manager::LoginDatabase> login_db, 22 scoped_ptr<password_manager::LoginDatabase> login_db,
22 PrefService* prefs) 23 PrefService* prefs)
23 : PasswordStore(main_thread_runner, nullptr), 24 : PasswordStore(main_thread_runner, nullptr),
24 login_metadata_db_(login_db.Pass()) { 25 login_metadata_db_(std::move(login_db)) {
25 DCHECK(login_metadata_db_); 26 DCHECK(login_metadata_db_);
26 migration_status_.Init(password_manager::prefs::kKeychainMigrationStatus, 27 migration_status_.Init(password_manager::prefs::kKeychainMigrationStatus,
27 prefs); 28 prefs);
28 if (migration_status_.GetValue() == 29 if (migration_status_.GetValue() ==
29 static_cast<int>(MigrationStatus::MIGRATED)) { 30 static_cast<int>(MigrationStatus::MIGRATED)) {
30 // The login database will be set later after initialization. 31 // The login database will be set later after initialization.
31 password_store_simple_ = 32 password_store_simple_ =
32 new SimplePasswordStoreMac(main_thread_runner, nullptr, nullptr); 33 new SimplePasswordStoreMac(main_thread_runner, nullptr, nullptr);
33 } else { 34 } else {
34 password_store_mac_ = 35 password_store_mac_ =
35 new PasswordStoreMac(main_thread_runner, nullptr, keychain.Pass()); 36 new PasswordStoreMac(main_thread_runner, nullptr, std::move(keychain));
36 } 37 }
37 } 38 }
38 39
39 PasswordStoreProxyMac::~PasswordStoreProxyMac() { 40 PasswordStoreProxyMac::~PasswordStoreProxyMac() {
40 } 41 }
41 42
42 bool PasswordStoreProxyMac::Init( 43 bool PasswordStoreProxyMac::Init(
43 const syncer::SyncableService::StartSyncFlare& flare) { 44 const syncer::SyncableService::StartSyncFlare& flare) {
44 // Set up a background thread. 45 // Set up a background thread.
45 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 46 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 90
90 void PasswordStoreProxyMac::InitOnBackgroundThread(MigrationStatus status) { 91 void PasswordStoreProxyMac::InitOnBackgroundThread(MigrationStatus status) {
91 DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread()); 92 DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
92 if (!login_metadata_db_->Init()) { 93 if (!login_metadata_db_->Init()) {
93 login_metadata_db_.reset(); 94 login_metadata_db_.reset();
94 LOG(ERROR) << "Could not create/open login database."; 95 LOG(ERROR) << "Could not create/open login database.";
95 } 96 }
96 97
97 if (status == MigrationStatus::MIGRATED) { 98 if (status == MigrationStatus::MIGRATED) {
98 password_store_simple_->InitWithTaskRunner(GetBackgroundTaskRunner(), 99 password_store_simple_->InitWithTaskRunner(GetBackgroundTaskRunner(),
99 login_metadata_db_.Pass()); 100 std::move(login_metadata_db_));
100 } else { 101 } else {
101 password_store_mac_->set_login_metadata_db(login_metadata_db_.get()); 102 password_store_mac_->set_login_metadata_db(login_metadata_db_.get());
102 password_store_mac_->InitWithTaskRunner(GetBackgroundTaskRunner()); 103 password_store_mac_->InitWithTaskRunner(GetBackgroundTaskRunner());
103 if (login_metadata_db_ && (status == MigrationStatus::NOT_STARTED || 104 if (login_metadata_db_ && (status == MigrationStatus::NOT_STARTED ||
104 status == MigrationStatus::FAILED_ONCE)) { 105 status == MigrationStatus::FAILED_ONCE)) {
105 // Let's try to migrate the passwords. 106 // Let's try to migrate the passwords.
106 if (password_store_mac_->ImportFromKeychain() == 107 if (password_store_mac_->ImportFromKeychain() ==
107 PasswordStoreMac::MIGRATION_OK) { 108 PasswordStoreMac::MIGRATION_OK) {
108 status = MigrationStatus::MIGRATED; 109 status = MigrationStatus::MIGRATED;
109 // Switch from |password_store_mac_| to |password_store_simple_|. 110 // Switch from |password_store_mac_| to |password_store_simple_|.
110 password_store_mac_->set_login_metadata_db(nullptr); 111 password_store_mac_->set_login_metadata_db(nullptr);
111 pending_ui_tasks_.push_back(base::Bind( 112 pending_ui_tasks_.push_back(base::Bind(
112 &PasswordStoreMac::ShutdownOnUIThread, password_store_mac_)); 113 &PasswordStoreMac::ShutdownOnUIThread, password_store_mac_));
113 password_store_mac_ = nullptr; 114 password_store_mac_ = nullptr;
114 DCHECK(!password_store_simple_); 115 DCHECK(!password_store_simple_);
115 password_store_simple_ = new SimplePasswordStoreMac( 116 password_store_simple_ = new SimplePasswordStoreMac(
116 main_thread_runner_, GetBackgroundTaskRunner(), 117 main_thread_runner_, GetBackgroundTaskRunner(),
117 login_metadata_db_.Pass()); 118 std::move(login_metadata_db_));
118 } else { 119 } else {
119 status = (status == MigrationStatus::FAILED_ONCE 120 status = (status == MigrationStatus::FAILED_ONCE
120 ? MigrationStatus::FAILED_TWICE 121 ? MigrationStatus::FAILED_TWICE
121 : MigrationStatus::FAILED_ONCE); 122 : MigrationStatus::FAILED_ONCE);
122 } 123 }
123 pending_ui_tasks_.push_back( 124 pending_ui_tasks_.push_back(
124 base::Bind(&PasswordStoreProxyMac::UpdateStatusPref, this, status)); 125 base::Bind(&PasswordStoreProxyMac::UpdateStatusPref, this, status));
125 } 126 }
126 } 127 }
127 if (!pending_ui_tasks_.empty()) { 128 if (!pending_ui_tasks_.empty()) {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 } 218 }
218 219
219 void PasswordStoreProxyMac::RemoveSiteStatsImpl(const GURL& origin_domain) { 220 void PasswordStoreProxyMac::RemoveSiteStatsImpl(const GURL& origin_domain) {
220 GetBackend()->RemoveSiteStatsImpl(origin_domain); 221 GetBackend()->RemoveSiteStatsImpl(origin_domain);
221 } 222 }
222 223
223 std::vector<scoped_ptr<password_manager::InteractionsStats>> 224 std::vector<scoped_ptr<password_manager::InteractionsStats>>
224 PasswordStoreProxyMac::GetSiteStatsImpl(const GURL& origin_domain) { 225 PasswordStoreProxyMac::GetSiteStatsImpl(const GURL& origin_domain) {
225 return GetBackend()->GetSiteStatsImpl(origin_domain); 226 return GetBackend()->GetSiteStatsImpl(origin_domain);
226 } 227 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698