Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1569393002: Revert of Add a class representing texture swizzle. (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add a class representing texture swizzle. (patchset #6 id:100001 of https://codereview.chromium.org/1567733005/ ) Reason for revert: Shader compilation failures when implicitly converting vec4 to float. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Debug/builds/3266/steps/dm/logs/stdio https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug/builds/3154/steps/dm/logs/stdio Original issue's description: > Add a class representing texture swizzle. > > Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps. > > Remove GrTextureAccess's swizzle and update users of it to swizzle in their shader code. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567733005 > > Committed: https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105 TBR=egdaniel@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3183a4136364cfe18b3584302e71ea528a018401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -219 lines) Patch
M include/gpu/GrTextureAccess.h View 2 chunks +47 lines, -8 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/GrSwizzle.h View 1 chunk +0 lines, -92 lines 0 comments Download
M src/gpu/GrTextureAccess.cpp View 3 chunks +70 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 6 chunks +5 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 19 chunks +44 lines, -48 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +33 lines, -20 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 2 chunks +65 lines, -15 lines 0 comments Download
M src/gpu/glsl/GrGLSLTextureSampler.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Add a class representing texture swizzle.
4 years, 11 months ago (2016-01-08 20:11:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569393002/1
4 years, 11 months ago (2016-01-08 20:11:26 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:11:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3183a4136364cfe18b3584302e71ea528a018401

Powered by Google App Engine
This is Rietveld 408576698