Add a class representing texture swizzle.

Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their shader code.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567733005

Committed: https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105

Committed: https://skia.googlesource.com/skia/+/cdee009886babe6df7743a9b5b3e2cc0a5f21adf

[bsalomon, 2016-01-07 22:16:00]

Description was changed from

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
==========

to

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-07 22:19:02]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-07 22:19:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567733005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567733005/20001

[commit-bot: I haz the power, 2016-01-07 22:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 22:19:48]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2016-01-08 17:24:09]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2016-01-08 17:24:18]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[bsalomon, 2016-01-08 17:39:44]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 17:39:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567733005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567733005/80001

[commit-bot: I haz the power, 2016-01-08 17:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 17:55:00]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-01-08 19:02:49]

lgtm with minor comments

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h
File src/gpu/GrSwizzle.h (right):

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h#new...
src/gpu/GrSwizzle.h:86: uint32_t* asUIntPtr() { return
SkTCast<uint32_t*>(fSwiz); }
is this ptr version needed somewhere?

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:456: // Requires various members are already correctly
initialized (e.g. fTextureRedSupport,
make this comment read better. "Requires that various members are...", or better
yet instead of various do we know which they are. Requests that
fTextureRedSupport, fTextureSwizzleSupport, <and the rest> have been
initialized.

[bsalomon, 2016-01-08 19:19:49]

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h
File src/gpu/GrSwizzle.h (right):

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h#new...
src/gpu/GrSwizzle.h:86: uint32_t* asUIntPtr() { return
SkTCast<uint32_t*>(fSwiz); }
On 2016/01/08 19:02:49, egdaniel wrote:
> is this ptr version needed somewhere?

Used in the assignment operator.

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:456: // Requires various members are already correctly
initialized (e.g. fTextureRedSupport,
On 2016/01/08 19:02:49, egdaniel wrote:
> make this comment read better. "Requires that various members are...", or
better
> yet instead of various do we know which they are. Requests that
> fTextureRedSupport, fTextureSwizzleSupport, <and the rest> have been
> initialized.

Done.

[bsalomon, 2016-01-08 19:19:54]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-08 19:19:55]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1567733005/#ps100001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-08 19:20:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567733005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567733005/100001

[bsalomon, 2016-01-08 19:31:54]

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h
File src/gpu/GrSwizzle.h (right):

https://codereview.chromium.org/1567733005/diff/80001/src/gpu/GrSwizzle.h#new...
src/gpu/GrSwizzle.h:86: uint32_t* asUIntPtr() { return
SkTCast<uint32_t*>(fSwiz); }
On 2016/01/08 19:02:49, egdaniel wrote:
> is this ptr version needed somewhere?

Actually I changed that. Will remove in a follow on patch.

[commit-bot: I haz the power, 2016-01-08 19:38:43]

Description was changed from

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105
==========

[commit-bot: I haz the power, 2016-01-08 19:38:44]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105

[mtklein, 2016-01-08 20:11:15]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1569393002/ by mtklein@google.com.

The reason for reverting is: Shader compilation failures when implicitly
converting vec4 to float.

https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-Sh...

https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Andr....

[bsalomon, 2016-01-08 20:59:40]

Description was changed from

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105
==========

to

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105
==========

[bsalomon, 2016-01-08 20:59:44]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-08 20:59:45]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1567733005/#ps120001
(title: "Add .a for color table FP texture reads.")

[commit-bot: I haz the power, 2016-01-08 20:59:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567733005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567733005/120001

[commit-bot: I haz the power, 2016-01-08 21:20:15]

Description was changed from

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105
==========

to

==========
Add a class representing texture swizzle.

Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.

Remove GrTextureAccess's swizzle and update users of it to swizzle in their
shader code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105

Committed:
https://skia.googlesource.com/skia/+/cdee009886babe6df7743a9b5b3e2cc0a5f21adf
==========

[commit-bot: I haz the power, 2016-01-08 21:20:15]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/cdee009886babe6df7743a9b5b3e2cc0a5f21adf