Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton, alyssar1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Moving many QUIC DFATALS over to QUIC_BUG Merge internal change: 111359954 BUG=

Patch Set 1 : #

Patch Set 2 : add unused flag to keep code consistent #

Total comments: 4

Patch Set 3 : remove comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -93 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A net/quic/quic_bug_tracker.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 14 chunks +34 lines, -34 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 12 chunks +14 lines, -15 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_session.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/stream_sequencer_buffer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1558423002 Patch 1

Dependent Patchsets:

Issue 1562833003 Patch 40001
Issue 1562833003 Patch 60001

Messages

Total messages: 6 (2 generated)
Zhongyi Shi
I skipped the flag in quic_bug_traker.h as well as flag flips. Chromium doesn't have any ...
4 years, 11 months ago (2016-01-06 23:04:37 UTC) #3
Ryan Hamilton
Couple of nits. https://codereview.chromium.org/1565883003/diff/40001/net/quic/quic_bug_tracker.h File net/quic/quic_bug_tracker.h (right): https://codereview.chromium.org/1565883003/diff/40001/net/quic/quic_bug_tracker.h#newcode3 net/quic/quic_bug_tracker.h:3: // // found in the LICENSE ...
4 years, 11 months ago (2016-01-07 00:36:14 UTC) #4
Zhongyi Shi
https://codereview.chromium.org/1565883003/diff/40001/net/quic/quic_bug_tracker.h File net/quic/quic_bug_tracker.h (right): https://codereview.chromium.org/1565883003/diff/40001/net/quic/quic_bug_tracker.h#newcode3 net/quic/quic_bug_tracker.h:3: // // found in the LICENSE file. On 2016/01/07 ...
4 years, 11 months ago (2016-01-07 00:45:56 UTC) #5
Ryan Hamilton
4 years, 11 months ago (2016-01-07 00:50:44 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698