Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 095e206910ca77f82cde50291e047e80782fb1da..6b71c70f4db3ab1a0579c1aa2562b7671a356c31 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -11,6 +11,7 @@
#include "net/quic/congestion_control/pacing_sender.h"
#include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/proto/cached_network_parameters.pb.h"
+#include "net/quic/quic_bug_tracker.h"
#include "net/quic/quic_connection_stats.h"
#include "net/quic/quic_flags.h"
#include "net/quic/quic_utils_chromium.h"
@@ -422,9 +423,9 @@ void QuicSentPacketManager::RecordSpuriousRetransmissions(
// ianswett: Prevents crash in b/20552846.
if (*it < unacked_packets_.GetLeastUnacked() ||
*it > unacked_packets_.largest_sent_packet()) {
- LOG(DFATAL) << "Retransmission out of range:" << *it
- << " least unacked:" << unacked_packets_.GetLeastUnacked()
- << " largest sent:" << unacked_packets_.largest_sent_packet();
+ QUIC_BUG << "Retransmission out of range:" << *it
+ << " least unacked:" << unacked_packets_.GetLeastUnacked()
+ << " largest sent:" << unacked_packets_.largest_sent_packet();
return;
}
const TransmissionInfo& retransmit_info =
@@ -569,9 +570,9 @@ bool QuicSentPacketManager::OnPacketSent(
if (original_packet_number != 0) {
if (!pending_retransmissions_.erase(original_packet_number)) {
- DLOG(DFATAL) << "Expected packet number to be in "
- << "pending_retransmissions_. packet_number: "
- << original_packet_number;
+ QUIC_BUG << "Expected packet number to be in "
+ << "pending_retransmissions_. packet_number: "
+ << original_packet_number;
}
}
@@ -787,8 +788,8 @@ bool QuicSentPacketManager::MaybeUpdateRTT(const QuicAckFrame& ack_frame,
unacked_packets_.GetTransmissionInfo(ack_frame.largest_observed);
// Ensure the packet has a valid sent time.
if (transmission_info.sent_time == QuicTime::Zero()) {
- LOG(DFATAL) << "Acked packet has zero sent time, largest_observed:"
- << ack_frame.largest_observed;
+ QUIC_BUG << "Acked packet has zero sent time, largest_observed:"
+ << ack_frame.largest_observed;
return false;
}
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698