net/quic/quic_bug_tracker.h - Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/quic_bug_tracker.h

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unused flag to keep code consistent Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // // Use of this source code is governed by a BSD-style license that can be

	3 // // found in the LICENSE file.
	Ryan Hamilton 2016/01/07 00:36:13 Remove the extra //? Remove the extra //? Zhongyi Shi 2016/01/07 00:45:56 Done. Show quoted text On 2016/01/07 00:36:13, Ryan Hamilton wrote: > Remove the extra //? Done.
	4 #ifndef NET_QUIC_QUIC_BUG_TRACKER_H_

	5 #define NET_QUIC_QUIC_BUG_TRACKER_H_

	6

	7 // For external QUIC, QUIC_BUG should be #defined to LOG(DFATAL) as client-side

	8 // log rate limiting is less important and chrome doesn't LOG_FIRST_N anyway.

	9 //

	10 // This file should change infrequently if ever, so update cost should be

	11 // minimal. Meanwhile we do want different macros so we can rate limit server

	12 // side, so the google3 shared code increments GFE varz, and chrome can have its

	13 // own custom hooks.
	Ryan Hamilton 2016/01/07 00:36:14 Please remove these comments as they're basically Please remove these comments as they're basically internal-only Zhongyi Shi 2016/01/07 00:45:56 Done. Show quoted text On 2016/01/07 00:36:14, Ryan Hamilton wrote: > Please remove these comments as they're basically internal-only Done.
	14 #define QUIC_BUG LOG(DFATAL)

	15 #endif // NET_QUIC_QUIC_BUG_TRACKER_H_

OLD	NEW

« no previous file with comments | « net/quic/crypto/quic_crypto_client_config.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »