Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_unacked_packet_map.cc ('k') | net/quic/stream_sequencer_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream.cc
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc
index f42687adcaac1e585db729b134e824827e1f9af7..6837b8b9327cf7c7099a30b53d403b15d7a2a55c 100644
--- a/net/quic/reliable_quic_stream.cc
+++ b/net/quic/reliable_quic_stream.cc
@@ -7,6 +7,7 @@
#include "base/logging.h"
#include "net/quic/iovector.h"
#include "net/quic/quic_ack_listener_interface.h"
+#include "net/quic/quic_bug_tracker.h"
#include "net/quic/quic_flags.h"
#include "net/quic/quic_flow_controller.h"
#include "net/quic/quic_session.h"
@@ -190,12 +191,12 @@ void ReliableQuicStream::WriteOrBufferData(
bool fin,
QuicAckListenerInterface* ack_listener) {
if (data.empty() && !fin) {
- LOG(DFATAL) << "data.empty() && !fin";
+ QUIC_BUG << "data.empty() && !fin";
return;
}
if (fin_buffered_) {
- LOG(DFATAL) << "Fin already buffered";
+ QUIC_BUG << "Fin already buffered";
return;
}
if (write_side_closed_) {
@@ -233,9 +234,8 @@ void ReliableQuicStream::OnCanWrite() {
pending_data->offset >= pending_data->data.size()) {
// This should be impossible because offset tracks the amount of
// pending_data written thus far.
- LOG(DFATAL) << "Pending offset is beyond available data. offset: "
- << pending_data->offset
- << " vs: " << pending_data->data.size();
+ QUIC_BUG << "Pending offset is beyond available data. offset: "
+ << pending_data->offset << " vs: " << pending_data->data.size();
return;
}
size_t remaining_len = pending_data->data.size() - pending_data->offset;
« no previous file with comments | « net/quic/quic_unacked_packet_map.cc ('k') | net/quic/stream_sequencer_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698