Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: net/quic/quic_unacked_packet_map.cc

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map.cc
diff --git a/net/quic/quic_unacked_packet_map.cc b/net/quic/quic_unacked_packet_map.cc
index 74dde00515e90e4bbad4ba6800839badef94dddc..6beb9bc667f527480ff941afbaaa9dba4ca85f7c 100644
--- a/net/quic/quic_unacked_packet_map.cc
+++ b/net/quic/quic_unacked_packet_map.cc
@@ -5,7 +5,7 @@
#include "net/quic/quic_unacked_packet_map.h"
#include "base/logging.h"
-#include "base/stl_util.h"
+#include "net/quic/quic_bug_tracker.h"
#include "net/quic/quic_connection_stats.h"
#include "net/quic/quic_flags.h"
#include "net/quic/quic_utils_chromium.h"
@@ -93,9 +93,9 @@ void QuicUnackedPacketMap::TransferRetransmissionInfo(
TransmissionInfo* info) {
if (old_packet_number < least_unacked_ ||
old_packet_number > largest_sent_packet_) {
- LOG(DFATAL) << "Old TransmissionInfo no longer exists for:"
- << old_packet_number << " least_unacked:" << least_unacked_
- << " largest_sent:" << largest_sent_packet_;
+ QUIC_BUG << "Old TransmissionInfo no longer exists for:"
+ << old_packet_number << " least_unacked:" << least_unacked_
+ << " largest_sent:" << largest_sent_packet_;
return;
}
DCHECK_GE(new_packet_number, least_unacked_ + unacked_packets_.size());
@@ -359,7 +359,7 @@ QuicTime QuicUnackedPacketMap::GetLastPacketSentTime() const {
}
++it;
}
- LOG(DFATAL) << "GetLastPacketSentTime requires in flight packets.";
+ QUIC_BUG << "GetLastPacketSentTime requires in flight packets.";
return QuicTime::Zero();
}
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698