Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: net/quic/quic_session.cc

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session.cc
diff --git a/net/quic/quic_session.cc b/net/quic/quic_session.cc
index ffb204338727d26845d8aad163b5913562c3fccb..bf1ba4a75d5ce85d94b0b40954591f385e50c4e9 100644
--- a/net/quic/quic_session.cc
+++ b/net/quic/quic_session.cc
@@ -7,6 +7,7 @@
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "net/quic/crypto/proof_verifier.h"
+#include "net/quic/quic_bug_tracker.h"
#include "net/quic/quic_connection.h"
#include "net/quic/quic_flags.h"
#include "net/quic/quic_flow_controller.h"
@@ -195,8 +196,7 @@ void QuicSession::OnConnectionClosed(QuicErrorCode error, bool from_peer) {
it->second->OnConnectionClosed(error, from_peer);
// The stream should call CloseStream as part of OnConnectionClosed.
if (dynamic_stream_map_.find(id) != dynamic_stream_map_.end()) {
- LOG(DFATAL) << ENDPOINT
- << "Stream failed to close under OnConnectionClosed";
+ QUIC_BUG << ENDPOINT << "Stream failed to close under OnConnectionClosed";
CloseStream(id);
}
}
@@ -260,7 +260,7 @@ void QuicSession::OnCanWrite() {
if (!(write_blocked_streams_.HasWriteBlockedCryptoOrHeadersStream() ||
write_blocked_streams_.HasWriteBlockedDataStreams())) {
// Writing one stream removed another!? Something's broken.
- LOG(DFATAL) << "WriteBlockedStream is missing";
+ QUIC_BUG << "WriteBlockedStream is missing";
connection_->CloseConnection(QUIC_INTERNAL_ERROR, false);
return;
}
@@ -319,7 +319,7 @@ void QuicSession::SendRstStream(QuicStreamId id,
QuicRstStreamErrorCode error,
QuicStreamOffset bytes_written) {
if (ContainsKey(static_stream_map_, id)) {
- LOG(DFATAL) << "Cannot send RST for a static stream with ID " << id;
+ QUIC_BUG << "Cannot send RST for a static stream with ID " << id;
return;
}
@@ -776,7 +776,7 @@ void QuicSession::MarkConnectionLevelWriteBlocked(QuicStreamId id,
<< "Priorities do not match. Got: " << static_cast<int>(priority)
<< " Expected: " << static_cast<int>(stream->Priority());
} else {
- LOG(DFATAL) << "Marking unknown stream " << id << " blocked.";
+ QUIC_BUG << "Marking unknown stream " << id << " blocked.";
}
#endif
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698