Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1562833003: relnote: Clear the FEC group in QuicPacketCreator when encryption_level is none and close the conne… (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi
Modified:
4 years, 11 months ago
Reviewers:
ianswett, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@26_CL_111359954
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Clear the FEC group in QuicPacketCreator when encryption_level is none and close the connection if SerializeFec is called. Protected by gfe2_reloadable_flag_never_write_unencrypted_data. When merging in Chromium, re-enable FLAGS_enable_quic_fec. Merge internal change: 111385311 BUG=

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : sync quic_error_map with quic_protocol #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -4 lines) Patch
M components/domain_reliability/util.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator.cc View 2 chunks +9 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 2 chunks +51 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
Zhongyi Shi
The FLAGS_enable_quic_fec is also re-enabled in this cl.
4 years, 11 months ago (2016-01-06 23:22:18 UTC) #2
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-07 00:36:22 UTC) #6
ianswett
4 years, 11 months ago (2016-01-07 04:08:55 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698