DevTools: merge uisourcecode's url-alike members.

DevTools: merge uisourcecode's url-alike members.

Committed: https://crrev.com/245b99911a8770cfc29689f5b8c85a9275924b3b
Cr-Commit-Position: refs/heads/master@{#368639}

[pfeldman, 2016-01-08 19:28:41]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-01-08 19:28:46]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-08 19:28:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564113003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564113003/1

[commit-bot: I haz the power, 2016-01-08 19:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 19:28:55]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pfeldman, 2016-01-08 19:31:27]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 19:33:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564113003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564113003/1

[dgozman, 2016-01-08 20:22:07]

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:80:
return this._urlForPath(fileSystemPath, uiSourceCode.url());
Calling urlForPath with url parameter is strange.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:89:
hasMappingForURL: function(url)
What about renaming some methods here to include networkURL?

hasMappingForNetworkURL
uiSourceCodeForNetworkURLForAnyTarget

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js:142:
var descriptor = String.sprintf("%s:%d:%d", uiLocation.uiSourceCode.url(),
uiLocation.lineNumber + 1, uiLocation.columnNumber + 1);
I think displayName suits better.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/FrontendWebSocketAPI.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/FrontendWebSocketAPI.js:41:
url = uiSourceCode.url();
Kill this file already!

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js:147:
this._path = uiSourceCode.url();
this._path -> this._url

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js:104:
var path = uiSourceCode.url();
Not sure about this change - may surprise users.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:151:
var url = projectType === WebInspector.projectTypes.Formatter ?
this.uiSourceCode().url() : networkURL;
Suspicious change. Why formatter should use url instead?

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:913: var
url = projectType === WebInspector.projectTypes.Formatter ? uiSourceCode.url() :
networkURL;
ditto

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:176: var
oldURI = this.url();
oldURL

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js:280: var
path = uiSourceCode.url();
path -> url

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js:426: var
projects = this.projectsForType(WebInspector.projectTypes.Network);
Search in all projects.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js:440:
filesystemUISourceCode: function(url)
Let's remove this one

[commit-bot: I haz the power, 2016-01-08 20:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 20:42:31]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-01-08 23:56:32]

All but below are Done.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js:142:
var descriptor = String.sprintf("%s:%d:%d", uiLocation.uiSourceCode.url(),
uiLocation.lineNumber + 1, uiLocation.columnNumber + 1);
On 2016/01/08 20:22:06, dgozman wrote:
> I think displayName suits better.

This is location like in console, it should not use displayName.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/FrontendWebSocketAPI.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/FrontendWebSocketAPI.js:41:
url = uiSourceCode.url();
Separate patch.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js:104:
var path = uiSourceCode.url();
On 2016/01/08 20:22:07, dgozman wrote:
> Not sure about this change - may surprise users.

This only differs by the (index) modulus.

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/1564113003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:151:
var url = projectType === WebInspector.projectTypes.Formatter ?
this.uiSourceCode().url() : networkURL;
On 2016/01/08 20:22:07, dgozman wrote:
> Suspicious change. Why formatter should use url instead?

We only generate formatted versions for network resources.

[dgozman, 2016-01-09 01:31:37]

lgtm

[pfeldman, 2016-01-11 18:27:48]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-11 18:28:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564113003/20001

[commit-bot: I haz the power, 2016-01-11 19:42:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-11 19:44:37]

Description was changed from

==========
DevTools: merge uisourcecode's url-alike members.
==========

to

==========
DevTools: merge uisourcecode's url-alike members.

Committed: https://crrev.com/245b99911a8770cfc29689f5b8c85a9275924b3b
Cr-Commit-Position: refs/heads/master@{#368639}
==========

[commit-bot: I haz the power, 2016-01-11 19:44:38]

Patchset 2 (id:??) landed as
https://crrev.com/245b99911a8770cfc29689f5b8c85a9275924b3b
Cr-Commit-Position: refs/heads/master@{#368639}