Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
index 7a053372b96cfdbb19f766c1ca338394a4912a63..d058305cfb36954134b401abf29d88d6244be802 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
@@ -257,13 +257,13 @@ InspectorTest.createBreakpointManager = function(targetManager, debuggerWorkspac
{
var breakpoint = event.data.breakpoint;
var uiLocation = event.data.uiLocation;
- InspectorTest.addResult(" breakpointAdded(" + [uiLocation.uiSourceCode.originURL(), uiLocation.lineNumber, uiLocation.columnNumber, breakpoint.condition(), breakpoint.enabled()].join(", ") + ")");
+ InspectorTest.addResult(" breakpointAdded(" + [uiLocation.uiSourceCode.url(), uiLocation.lineNumber, uiLocation.columnNumber, breakpoint.condition(), breakpoint.enabled()].join(", ") + ")");
}
function breakpointRemoved(event)
{
var uiLocation = event.data.uiLocation;
- InspectorTest.addResult(" breakpointRemoved(" + [uiLocation.uiSourceCode.originURL(), uiLocation.lineNumber, uiLocation.columnNumber].join(", ") + ")");
+ InspectorTest.addResult(" breakpointRemoved(" + [uiLocation.uiSourceCode.url(), uiLocation.lineNumber, uiLocation.columnNumber].join(", ") + ")");
}
var targets = targetManager.targets();
var mappingForManager;
@@ -284,7 +284,7 @@ InspectorTest.createBreakpointManager = function(targetManager, debuggerWorkspac
InspectorTest.setBreakpoint = function(breakpointManager, uiSourceCode, lineNumber, columnNumber, condition, enabled, setBreakpointCallback)
{
- InspectorTest.addResult(" Setting breakpoint at " + uiSourceCode.originURL() + ":" + lineNumber + ":" + columnNumber + " enabled:" + enabled + " condition:" + condition);
+ InspectorTest.addResult(" Setting breakpoint at " + uiSourceCode.url() + ":" + lineNumber + ":" + columnNumber + " enabled:" + enabled + " condition:" + condition);
if (setBreakpointCallback)
window.setBreakpointCallback = setBreakpointCallback;
return breakpointManager.setBreakpoint(uiSourceCode, lineNumber, columnNumber, condition, enabled);
@@ -292,7 +292,7 @@ InspectorTest.setBreakpoint = function(breakpointManager, uiSourceCode, lineNumb
InspectorTest.removeBreakpoint = function(breakpointManager, uiSourceCode, lineNumber, columnNumber)
{
- InspectorTest.addResult(" Removing breakpoint at " + uiSourceCode.originURL() + ":" + lineNumber + ":" + columnNumber);
+ InspectorTest.addResult(" Removing breakpoint at " + uiSourceCode.url() + ":" + lineNumber + ":" + columnNumber);
breakpointManager.findBreakpoint(uiSourceCode, lineNumber, columnNumber).remove();
}
@@ -317,7 +317,7 @@ InspectorTest.dumpBreakpointLocations = function(breakpointManager)
return a.lineNumber - b.lineNumber;
});
var networkURL = InspectorTest.testNetworkMapping.networkURL(uiSourceCode);
- InspectorTest.addResult(" UISourceCode (url='" + networkURL + "', uri='" + uiSourceCode.uri() + "')");
+ InspectorTest.addResult(" UISourceCode (url='" + networkURL + "', uri='" + uiSourceCode.url() + "')");
for (var i = 0; i < locations.length; ++i)
InspectorTest.addResult(" Location: (" + locations[i].lineNumber + ", " + locations[i].columnNumber + ")");
}

Powered by Google App Engine
This is Rietveld 408576698