third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html

index 2c80a209df3f82be3938609d2ae9f2f98f71a448..a13ecb497019d7632565af6ee140c09cd2ca36b9 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html

@@ -72,7 +72,7 @@ function test()

var uiSourceCodes = panel._workspace.uiSourceCodes();

var ignored = true;

for (var i = 0; i < uiSourceCodes.length && ignored; ++i) {

- if (uiSourceCodes[i].originURL().indexOf("inlineScriptURL.js") !== -1)

+ if (uiSourceCodes[i].url().indexOf("inlineScriptURL.js") !== -1)

ignored = false;

}

if (ignored)

@@ -104,7 +104,7 @@ function test()

var panel = WebInspector.panels.sources;

var uiSourceCodes = panel._workspace.uiSourceCodes();

for (var i = 0; i < uiSourceCodes.length; ++i) {

- if (uiSourceCodes[i].originURL().indexOf("scriptWithPoorSourceURL.js") !== -1)

+ if (uiSourceCodes[i].url().indexOf("scriptWithPoorSourceURL.js") !== -1)

InspectorTest.addResult("FAILED: poor sourceURL comment in script was used as a script name");

}

next();