third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

index e5798f0800b2348b32c3535aef830de27483dd81..570a7f2dcf11f13d2a1c5c8c8d2aca8ec107a252 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

@@ -148,7 +148,7 @@ WebInspector.SourcesSearchScope.prototype = {

if (dirtyOnly && !uiSourceCode.isDirty())

continue;

if (this._searchConfig.filePathMatchesFileQuery(uiSourceCode.fullDisplayName()))

- result.push(uiSourceCode.path());

+ result.push(uiSourceCode.url());

}

result.sort(String.naturalOrderComparator);

return result;

@@ -175,7 +175,7 @@ WebInspector.SourcesSearchScope.prototype = {

var uiSourceCodes = [];

for (var i = 0; i < files.length; ++i) {

- var uiSourceCode = project.uiSourceCode(files[i]);

+ var uiSourceCode = project.uiSourceCodeForURL(files[i]);

if (uiSourceCode)

uiSourceCodes.push(uiSourceCode);

}