third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/workspace-mapping.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

index 7477b7433ad3d4f1abfb8fad7907988bc1694e18..4e665e068d4991cf3833ec62334061c83ca05c00 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

@@ -86,7 +86,7 @@ WebInspector.BreakpointManager.prototype = {

var networkURL = this._networkMapping.networkURL(uiSourceCode)

if (!networkURL)

return "";

- return uiSourceCode.uri();

+ return uiSourceCode.url();

/**

@@ -243,7 +243,7 @@ WebInspector.BreakpointManager.prototype = {

return breakpoint;

}

var projectId = uiSourceCode.project().id();

- var path = uiSourceCode.path();

+ var path = uiSourceCode.url();

var sourceFileId = this._sourceFileId(uiSourceCode);

breakpoint = new WebInspector.BreakpointManager.Breakpoint(this, projectId, path, sourceFileId, lineNumber, columnNumber, condition, enabled);

if (!this._breakpointsForPrimaryUISourceCode.get(uiSourceCode))