third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-request-revision-content.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js

index bffd2940c1593afae2f73f91af504b9827b699b5..97795215575d334d2962cc7746b2ae5b1fa7e6b4 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-test.js

@@ -41,7 +41,7 @@ InspectorTest.runSearchAndDumpResults = function(scope, searchConfig, sortByURI,

{

function comparator(searchResultA, searchResultB)

{

- return searchResultA.uiSourceCode.uri().compareTo(searchResultB.uiSourceCode.uri());

+ return searchResultA.uiSourceCode.url().compareTo(searchResultB.uiSourceCode.url());

}

if (sortByURI)

searchResults.sort(comparator);

@@ -53,7 +53,7 @@ InspectorTest.runSearchAndDumpResults = function(scope, searchConfig, sortByURI,

if (!searchMatches.length)

continue;

- InspectorTest.addResult("Search result #" + (i + 1) + ": uiSourceCode.uri = " + uiSourceCode.uri());

+ InspectorTest.addResult("Search result #" + (i + 1) + ": uiSourceCode.url = " + uiSourceCode.url());

for (var j = 0; j < searchMatches.length; ++j) {

var lineNumber = searchMatches[j].lineNumber;

var lineContent = searchMatches[j].lineContent;