Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
index c8df7761489278604019d0d5a2cbe0c10ae74195..3ae09ab2f001669ba53c33cc7ee956016c1b28cd 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
@@ -772,20 +772,20 @@ WebInspector.SourcesView.SwitchFileActionDelegate._nextFile = function(currentUI
var uiSourceCodes = currentUISourceCode.project().uiSourceCodes();
var candidates = [];
- var path = currentUISourceCode.parentPath();
+ var url = currentUISourceCode.parentURL();
var name = currentUISourceCode.name();
var namePrefix = fileNamePrefix(name);
for (var i = 0; i < uiSourceCodes.length; ++i) {
var uiSourceCode = uiSourceCodes[i];
- if (path !== uiSourceCode.parentPath())
+ if (url !== uiSourceCode.parentURL())
continue;
if (fileNamePrefix(uiSourceCode.name()) === namePrefix)
candidates.push(uiSourceCode.name());
}
candidates.sort(String.naturalOrderComparator);
var index = mod(candidates.indexOf(name) + 1, candidates.length);
- var fullPath = (path ? path + "/" : "") + candidates[index];
- var nextUISourceCode = currentUISourceCode.project().uiSourceCode(fullPath);
+ var fullURL = (url ? url + "/" : "") + candidates[index];
+ var nextUISourceCode = currentUISourceCode.project().uiSourceCodeForURL(fullURL);
return nextUISourceCode !== currentUISourceCode ? nextUISourceCode : null;
}

Powered by Google App Engine
This is Rietveld 408576698