Subzero. Refactoring.

Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the
rest of subzero. In this CL, all the references to target-specific files
(e.g., IceTargetLoweringX8632.h) are removed from target-independent
files.

This CL also changes the named constructors in the Target-specific
classes (e.g., TargetX8632::create()) to return unique_ptrs.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=53611e2c39b36db641a1b0cd9c6eb2174f696f79

[John, 2015-12-28 19:19:16]

jpp@chromium.org changed reviewers:
+ stichnot@chromium.org

[John, 2015-12-28 19:22:14]

Description was changed from

==========
Subzero. Refactoring.

1) TargetLowering::create returns a unique_ptr;

2) TargetX::create return unique_ptr;

3) TargetLowering::staticInit() static_asserts if TargetX::staticInit
is undefined.

BUG=
==========

to

==========
Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the rest of
subzero. In this CL, all the references to target-specific files (e.g.,
IceTargetLoweringX8632.h) are removed from target-independent files.

This CL also changes the named constructors in the Target-specific classes
(e.g., TargetX8632::create()) to return unique_ptrs.
BUG=
==========

[Jim Stichnoth, 2015-12-30 01:26:43]

lgtm

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.cpp
File src/IceTargetLowering.cpp (right):

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.c...
src/IceTargetLowering.cpp:30: // implementations by forbidden #include of
target-specific header files
forbidding

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.c...
src/IceTargetLowering.cpp:147: } // Call the specified target's static
initializer.
Is this comment out of place?

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:49: } // end of namespace ARM32
MIPS32

[John, 2015-12-30 15:21:27]

Description was changed from

==========
Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the rest of
subzero. In this CL, all the references to target-specific files (e.g.,
IceTargetLoweringX8632.h) are removed from target-independent files.

This CL also changes the named constructors in the Target-specific classes
(e.g., TargetX8632::create()) to return unique_ptrs.
BUG=
==========

to

==========
Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the
rest of subzero. In this CL, all the references to target-specific files
(e.g., IceTargetLoweringX8632.h) are removed from target-independent
files.

This CL also changes the named constructors in the Target-specific
classes (e.g., TargetX8632::create()) to return unique_ptrs.

BUG=
==========

[John, 2015-12-30 15:30:14]

Description was changed from

==========
Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the
rest of subzero. In this CL, all the references to target-specific files
(e.g., IceTargetLoweringX8632.h) are removed from target-independent
files.

This CL also changes the named constructors in the Target-specific
classes (e.g., TargetX8632::create()) to return unique_ptrs.

BUG=
==========

to

==========
Subzero. Refactoring.

This is the first step towards hiding backend-specific stuff from the
rest of subzero. In this CL, all the references to target-specific files
(e.g., IceTargetLoweringX8632.h) are removed from target-independent
files.

This CL also changes the named constructors in the Target-specific
classes (e.g., TargetX8632::create()) to return unique_ptrs.

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2015-12-30 15:30:15]

Committed patchset #6 (id:90001) manually as
53611e2c39b36db641a1b0cd9c6eb2174f696f79 (presubmit successful).

[John, 2016-01-19 20:37:30]

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.cpp
File src/IceTargetLowering.cpp (right):

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.c...
src/IceTargetLowering.cpp:30: // implementations by forbidden #include of
target-specific header files
On 2015/12/30 01:26:42, stichnot wrote:
> forbidding

Done.

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLowering.c...
src/IceTargetLowering.cpp:147: } // Call the specified target's static
initializer.
On 2015/12/30 01:26:42, stichnot wrote:
> Is this comment out of place?

Done.

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/1551633002/diff/10007/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:49: } // end of namespace ARM32
On 2015/12/30 01:26:43, stichnot wrote:
> MIPS32

Done.