Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/IceTargetLoweringMIPS32.h

Issue 1551633002: Subzero. Refactoring. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringMIPS32.h
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index 60c62dd105d3dba053a96266c8a039dc965795cc..1c6627e2aec57592d3c6866e82275546edc106d2 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -16,6 +16,7 @@
#ifndef SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H
#define SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H
+#include "IceAssemblerMIPS32.h"
#include "IceDefs.h"
#include "IceInstMIPS32.h"
#include "IceRegistersMIPS32.h"
@@ -29,9 +30,16 @@ class TargetMIPS32 : public TargetLowering {
TargetMIPS32 &operator=(const TargetMIPS32 &) = delete;
public:
+ ~TargetMIPS32() override = default;
+
static void staticInit();
- // TODO(jvoung): return a unique_ptr.
- static TargetMIPS32 *create(Cfg *Func) { return new TargetMIPS32(Func); }
+ static std::unique_ptr<::Ice::TargetLowering> create(Cfg *Func) {
+ return makeUnique<TargetMIPS32>(Func);
+ }
+
+ std::unique_ptr<::Ice::Assembler> createAssembler() const override {
+ return makeUnique<MIPS32::AssemblerMIPS32>();
+ }
void translateOm1() override;
void translateO2() override;
@@ -257,7 +265,7 @@ protected:
VarList PhysicalRegisters[IceType_NUM];
private:
- ~TargetMIPS32() override = default;
+ ENABLE_MAKE_UNIQUE;
};
class TargetDataMIPS32 final : public TargetDataLowering {
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698