Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/IceTargetLoweringARM32.h

Issue 1551633002: Subzero. Refactoring. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index 306aaa92373c07d6650afb8cf67d896fe479076b..fef162da62c4248775e97471cc6f0a28a40f5bb5 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -16,6 +16,7 @@
#ifndef SUBZERO_SRC_ICETARGETLOWERINGARM32_H
#define SUBZERO_SRC_ICETARGETLOWERINGARM32_H
+#include "IceAssemblerARM32.h"
#include "IceDefs.h"
#include "IceInstARM32.h"
#include "IceRegistersARM32.h"
@@ -55,9 +56,17 @@ class TargetARM32 : public TargetLowering {
TargetARM32 &operator=(const TargetARM32 &) = delete;
public:
+ ~TargetARM32() = default;
+
static void staticInit();
// TODO(jvoung): return a unique_ptr.
- static TargetARM32 *create(Cfg *Func) { return new TargetARM32(Func); }
+ static std::unique_ptr<::Ice::TargetLowering> create(Cfg *Func) {
+ return makeUnique<TargetARM32>(Func);
+ }
+
+ std::unique_ptr<::Ice::Assembler> createAssembler() const override {
+ return makeUnique<ARM32::AssemblerARM32>();
+ }
void initNodeForLowering(CfgNode *Node) override {
Computations.forgetProducers();
@@ -1057,7 +1066,7 @@ protected:
};
private:
- ~TargetARM32() override = default;
+ ENABLE_MAKE_UNIQUE;
OperandARM32Mem *formAddressingMode(Type Ty, Cfg *Func, const Inst *LdSt,
Operand *Base);
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698