Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1543183002: Switch to standard integer types in ui/gfx/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, rsesek+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in ui/gfx/. BUG=138542 TBR=sky@chromium.org Committed: https://crrev.com/c89eb8d4ae7cdb55ceeb51bf22e31163ead95ab5 Cr-Commit-Position: refs/heads/master@{#366731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -314 lines) Patch
M ui/gfx/android/device_display_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/android/gfx_jni_registrar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/android/java_bitmap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/android/shared_device_display_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/android/view_configuration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation_container_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/linear_animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/linear_animation.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/animation/multi_animation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/animation/slide_animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/slide_animation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/test_animation_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/throb_animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/tween.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/tween.cc View 3 chunks +23 lines, -31 lines 0 comments Download
M ui/gfx/animation/tween_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gfx/blit.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 7 chunks +53 lines, -52 lines 0 comments Download
M ui/gfx/break_list.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/break_list_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/buffer_format_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/buffer_format_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/canvas.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/gfx/canvas.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/canvas_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/chromeos/codec/jpeg_codec_robust_slow_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/codec/jpeg_codec_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gfx/codec/png_codec.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/codec/png_codec.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/codec/png_codec_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/color_analysis.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/color_profile.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/color_profile.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/color_profile_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/color_profile_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/color_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/color_utils.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M ui/gfx/display.h View 4 chunks +11 lines, -10 lines 0 comments Download
M ui/gfx/display.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/display_change_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/display_change_notifier.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/gfx/display_change_notifier_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/font.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font_fallback_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font_fallback_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/font_list_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font_render_params_linux.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/font_render_params_linux_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font_render_params_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/font_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/gdi_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/generic_shared_memory_id.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/geometry/box_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/geometry/matrix3_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/geometry/point.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/point.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/gfx/geometry/point3_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/geometry/point_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/geometry/quad_f.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/geometry/quad_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/geometry/rect.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/rect.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/rect_f.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/rect_f.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/rect_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gfx/geometry/scroll_offset_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/geometry/size.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/size.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/vector2d.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/geometry/vector2d.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/geometry/vector2d_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/geometry/vector3d_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/icon_util.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gfx/icon_util.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M ui/gfx/icon_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/image/canvas_image_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/image/image_ios.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image_ios_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/image/image_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image_mac_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/image/image_skia.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_util_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/image/image_unittest_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/image/image_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/image/image_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/interpolated_transform.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/interpolated_transform_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/ios/NSString+CrStringDrawing.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/ios/uikit_util_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/gfx/mac/io_surface_manager.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M ui/gfx/mac/scoped_cocoa_disable_screen_updates.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/native_pixmap_handle_ozone.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/native_widget_types.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/nine_image_painter.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/nine_image_painter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/gfx/paint_throbber.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/paint_vector_icon.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/paint_vector_icon.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/path.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/path_win_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/platform_font.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/platform_font_ios.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/platform_font_ios.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/platform_font_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/platform_font_linux_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/platform_font_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/platform_font_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_mac_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/gfx/range/range.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/range/range_f.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/range/range_f.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/range/range_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/render_text.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/render_text.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/render_text_harfbuzz.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M ui/gfx/render_text_mac.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/render_text_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/render_text_unittest.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M ui/gfx/scoped_canvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/scoped_cg_context_save_gstate_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/scoped_sk_region.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/scoped_ui_graphics_push_context_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/screen_mac.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/gfx/screen_type_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/screen_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/screen_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/screen_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/scrollbar_size.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/selection_model.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/sequential_id_generator.h View 2 chunks +13 lines, -11 lines 0 comments Download
M ui/gfx/sequential_id_generator.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M ui/gfx/sequential_id_generator_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/gfx/shadow_value.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/shadow_value_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/skbitmap_operations.cc View 8 chunks +23 lines, -21 lines 0 comments Download
M ui/gfx/skbitmap_operations_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/skia_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/skrect_conversion_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/sys_color_change_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/test/fontconfig_util_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/test/fontconfig_util_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/test/run_all_unittests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/text_elider.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/text_elider.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/text_elider_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/text_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/text_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/gfx/text_utils_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/transform_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gfx/transform_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/utf16_indexing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/utf16_indexing_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/win/direct_manipulation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/win/direct_manipulation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/win/direct_write.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/win/scoped_set_map_mode.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/singleton_hwnd.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/win/window_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/win/window_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/x/x11_atom_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/x/x11_error_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/x/x11_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/x/x11_switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/x/x11_types.h View 2 chunks +22 lines, -12 lines 0 comments Download
M ui/gfx/x/x11_types.cc View 3 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543183002/1
5 years ago (2015-12-23 06:32:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 08:09:19 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-23 08:10:11 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c89eb8d4ae7cdb55ceeb51bf22e31163ead95ab5
Cr-Commit-Position: refs/heads/master@{#366731}

Powered by Google App Engine
This is Rietveld 408576698