Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: ui/gfx/sequential_id_generator.cc

Issue 1543183002: Switch to standard integer types in ui/gfx/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gfx/sequential_id_generator.h ('k') | ui/gfx/sequential_id_generator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gfx/sequential_id_generator.h" 5 #include "ui/gfx/sequential_id_generator.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace { 9 namespace {
10 10
11 // Removes |key| from |first|, and |first[key]| from |second|. 11 // Removes |key| from |first|, and |first[key]| from |second|.
12 template<typename T> 12 template <typename T>
13 void Remove(uint32 key, T* first, T* second) { 13 void Remove(uint32_t key, T* first, T* second) {
14 typename T::iterator iter = first->find(key); 14 typename T::iterator iter = first->find(key);
15 if (iter == first->end()) 15 if (iter == first->end())
16 return; 16 return;
17 17
18 uint32 second_key = iter->second; 18 uint32_t second_key = iter->second;
19 first->erase(iter); 19 first->erase(iter);
20 20
21 iter = second->find(second_key); 21 iter = second->find(second_key);
22 DCHECK(iter != second->end()); 22 DCHECK(iter != second->end());
23 second->erase(iter); 23 second->erase(iter);
24 } 24 }
25 25
26 } // namespace 26 } // namespace
27 27
28 namespace ui { 28 namespace ui {
29 29
30 SequentialIDGenerator::SequentialIDGenerator(uint32 min_id) 30 SequentialIDGenerator::SequentialIDGenerator(uint32_t min_id)
31 : min_id_(min_id), 31 : min_id_(min_id), min_available_id_(min_id) {}
32 min_available_id_(min_id) {
33 }
34 32
35 SequentialIDGenerator::~SequentialIDGenerator() { 33 SequentialIDGenerator::~SequentialIDGenerator() {
36 } 34 }
37 35
38 uint32 SequentialIDGenerator::GetGeneratedID(uint32 number) { 36 uint32_t SequentialIDGenerator::GetGeneratedID(uint32_t number) {
39 IDMap::iterator find = number_to_id_.find(number); 37 IDMap::iterator find = number_to_id_.find(number);
40 if (find != number_to_id_.end()) 38 if (find != number_to_id_.end())
41 return find->second; 39 return find->second;
42 40
43 int id = GetNextAvailableID(); 41 int id = GetNextAvailableID();
44 number_to_id_.insert(std::make_pair(number, id)); 42 number_to_id_.insert(std::make_pair(number, id));
45 id_to_number_.insert(std::make_pair(id, number)); 43 id_to_number_.insert(std::make_pair(id, number));
46 return id; 44 return id;
47 } 45 }
48 46
49 bool SequentialIDGenerator::HasGeneratedIDFor(uint32 number) const { 47 bool SequentialIDGenerator::HasGeneratedIDFor(uint32_t number) const {
50 return number_to_id_.find(number) != number_to_id_.end(); 48 return number_to_id_.find(number) != number_to_id_.end();
51 } 49 }
52 50
53 void SequentialIDGenerator::ReleaseGeneratedID(uint32 id) { 51 void SequentialIDGenerator::ReleaseGeneratedID(uint32_t id) {
54 UpdateNextAvailableIDAfterRelease(id); 52 UpdateNextAvailableIDAfterRelease(id);
55 Remove(id, &id_to_number_, &number_to_id_); 53 Remove(id, &id_to_number_, &number_to_id_);
56 } 54 }
57 55
58 void SequentialIDGenerator::ReleaseNumber(uint32 number) { 56 void SequentialIDGenerator::ReleaseNumber(uint32_t number) {
59 DCHECK_GT(number_to_id_.count(number), 0U); 57 DCHECK_GT(number_to_id_.count(number), 0U);
60 UpdateNextAvailableIDAfterRelease(number_to_id_[number]); 58 UpdateNextAvailableIDAfterRelease(number_to_id_[number]);
61 Remove(number, &number_to_id_, &id_to_number_); 59 Remove(number, &number_to_id_, &id_to_number_);
62 } 60 }
63 61
64 void SequentialIDGenerator::ResetForTest() { 62 void SequentialIDGenerator::ResetForTest() {
65 number_to_id_.clear(); 63 number_to_id_.clear();
66 id_to_number_.clear(); 64 id_to_number_.clear();
67 min_available_id_ = min_id_; 65 min_available_id_ = min_id_;
68 } 66 }
69 67
70 uint32 SequentialIDGenerator::GetNextAvailableID() { 68 uint32_t SequentialIDGenerator::GetNextAvailableID() {
71 const uint32 kMaxID = 128; 69 const uint32_t kMaxID = 128;
72 while (id_to_number_.count(min_available_id_) > 0 && 70 while (id_to_number_.count(min_available_id_) > 0 &&
73 min_available_id_ < kMaxID) { 71 min_available_id_ < kMaxID) {
74 ++min_available_id_; 72 ++min_available_id_;
75 } 73 }
76 if (min_available_id_ >= kMaxID) 74 if (min_available_id_ >= kMaxID)
77 min_available_id_ = min_id_; 75 min_available_id_ = min_id_;
78 return min_available_id_; 76 return min_available_id_;
79 } 77 }
80 78
81 void SequentialIDGenerator::UpdateNextAvailableIDAfterRelease(uint32 id) { 79 void SequentialIDGenerator::UpdateNextAvailableIDAfterRelease(uint32_t id) {
82 if (id < min_available_id_) { 80 if (id < min_available_id_) {
83 min_available_id_ = id; 81 min_available_id_ = id;
84 DCHECK_GE(min_available_id_, min_id_); 82 DCHECK_GE(min_available_id_, min_id_);
85 } 83 }
86 } 84 }
87 85
88 } // namespace ui 86 } // namespace ui
OLDNEW
« no previous file with comments | « ui/gfx/sequential_id_generator.h ('k') | ui/gfx/sequential_id_generator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698