Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Get rid of most instance of 'foo != NULL' TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1512763013 . (cherry picked from commit e3c7c2b54348da4a6939f6672f6c6bff126815a7) Committed: https://pdfium.googlesource.com/pdfium/+/96660d6f382204339d6b1aadc3913303d436e252

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -1009 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fdrm/crypto/fx_crypt_sha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 4 chunks +7 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 6 chunks +7 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 6 chunks +5 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 12 chunks +11 lines, -13 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 25 chunks +29 lines, -29 lines 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 14 chunks +13 lines, -21 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_basic_list.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 7 chunks +14 lines, -16 lines 0 comments Download
M core/src/fxcrt/fx_basic_plex.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M core/src/fxcrt/fx_basic_utf.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxcrt/xml_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CheckBox.cpp View 3 chunks +4 lines, -14 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 7 chunks +5 lines, -13 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 10 chunks +10 lines, -12 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 34 chunks +16 lines, -79 lines 1 comment Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 6 chunks +2 lines, -6 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_RadioButton.cpp View 4 chunks +1 line, -10 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 11 chunks +6 lines, -20 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 13 chunks +3 lines, -59 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 31 chunks +13 lines, -37 lines 1 comment Download
M fpdfsdk/src/fsdk_baseannot.cpp View 5 chunks +0 lines, -14 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 43 chunks +14 lines, -136 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 10 chunks +3 lines, -17 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_module.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 17 chunks +0 lines, -39 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 76 chunks +34 lines, -149 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 10 chunks +0 lines, -10 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 9 chunks +9 lines, -17 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 12 chunks +3 lines, -21 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 4 chunks +1 line, -8 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 17 chunks +0 lines, -35 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 7 chunks +1 line, -37 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 7 chunks +2 lines, -35 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Lei Zhang
TBR We also conflicted in fpdfsdk/src/fsdk_baseform.cpp and fpdfsdk/src/javascript/Field.cpp but they weren't anything serious either. https://codereview.chromium.org/1529553003/diff/1/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp ...
5 years ago (2015-12-15 02:27:18 UTC) #2
Lei Zhang
5 years ago (2015-12-15 02:27:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
96660d6f382204339d6b1aadc3913303d436e252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698