core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 5467cfdaec62274b68b573bf9dc9b7bd2ee30ca7..7febc7932f09b503480933ffccb5fe40419c3922 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -429,7 +429,7 @@ CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTA* pLogFont,

#if (_FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_)

uint32_t FX_GetLangHashCode(const FX_CHAR* pStr) {

- FXSYS_assert(pStr != NULL);

+ FXSYS_assert(pStr);

int32_t iLength = FXSYS_strlen(pStr);

const FX_CHAR* pStrEnd = pStr + iLength;

uint32_t uHashCode = 0;