core/src/fdrm/crypto/fx_crypt_sha.cpp - Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fdrm/crypto/fx_crypt_sha.cpp

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fdrm/crypto/fx_crypt_sha.cpp

diff --git a/core/src/fdrm/crypto/fx_crypt_sha.cpp b/core/src/fdrm/crypto/fx_crypt_sha.cpp

index 21046f1df29f038e92cd298d19c8b568e5971a62..ecefdde05a8675aff0cf67f29927ce4626bd58ff 100644

--- a/core/src/fdrm/crypto/fx_crypt_sha.cpp

+++ b/core/src/fdrm/crypto/fx_crypt_sha.cpp

@@ -369,7 +369,7 @@ typedef struct {

uint8_t buffer[128];

} sha384_context;

uint64_t FX_ato64i(const FX_CHAR* str) {

- FXSYS_assert(str != NULL);

+ FXSYS_assert(str);

uint64_t ret = 0;

int len = (int)FXSYS_strlen(str);

len = len > 16 ? 16 : len;