Merge to XFA: Get rid of most instance of 'foo != NULL'

fpdfsdk/src/pdfwindow/PWL_Note.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/pdfwindow/PDFWindow.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Button.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Caret.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h"
@@ skipping 29 matching lines @@
 
 void CPWL_Note_Options::SetTextColor(const CPWL_Color& color) {
   CPWL_Wnd::SetTextColor(color);
 
   if (m_pText)
     m_pText->SetTextColor(color);
 }
 
 void CPWL_Note_Options::RePosChildWnd() {
   if (IsValid()) {
-    ASSERT(m_pText != NULL);
-
     CPDF_Rect rcClient = GetClientRect();
 
     if (rcClient.Width() > 15.0f) {
       rcClient.right -= 15.0f;
       m_pText->Move(rcClient, TRUE, FALSE);
       m_pText->SetVisible(TRUE);
     } else {
       m_pText->Move(CPDF_Rect(0, 0, 0, 0), TRUE, FALSE);
       m_pText->SetVisible(FALSE);
     }
@@ skipping 34 matching lines @@
   path.SetPoint(2, pt3.x, pt3.y, FXPT_LINETO);
   path.SetPoint(3, pt1.x, pt1.y, FXPT_LINETO);
 
   pDevice->DrawPath(
       &path, pUser2Device, NULL,
       CPWL_Utils::PWLColorToFXColor(GetTextColor(), GetTransparency()), 0,
       FXFILL_ALTERNATE);
 }
 
 CPDF_Rect CPWL_Note_Options::GetContentRect() const {
-  ASSERT(m_pText != NULL);
-
   CPDF_Rect rcText = m_pText->GetContentRect();
   rcText.right += 15.0f;
   return rcText;
 }
 
 /* ------------------------------- CPWL_Note_Edit ------------------------------
  */
 
 CPWL_Note_Edit::CPWL_Note_Edit()
     : m_bEnableNotify(TRUE),
@@ skipping 536 matching lines @@
       CPWL_Color(COLORTYPE_RGB, 240 / 255.0f, 240 / 255.0f, 240 / 255.0f);
   ccp.dwFlags = PWS_VISIBLE | PWS_CHILD | PWS_BACKGROUND;
   m_pContents->Create(ccp);
   m_pContents->SetItemSpace(POPUP_ITEM_SPACE);
   m_pContents->SetTopSpace(POPUP_ITEM_SPACE);
   m_pContents->SetBottomSpace(POPUP_ITEM_SPACE);
 }
 
 void CPWL_NoteItem::RePosChildWnd() {
   if (IsValid()) {
-    ASSERT(m_pSubject != NULL);
-    ASSERT(m_pDateTime != NULL);
-    ASSERT(m_pContents != NULL);
-
     CPDF_Rect rcClient = GetClientRect();
 
     CPDF_Rect rcSubject = rcClient;
     rcSubject.left += POPUP_ITEM_TEXT_INDENT;
     rcSubject.top = rcClient.top;
     rcSubject.right =
         PWL_MIN(rcSubject.left + m_pSubject->GetContentRect().Width() + 1.0f,
                 rcClient.right);
     rcSubject.bottom = rcSubject.top - m_pSubject->GetContentRect().Height();
     rcSubject.Normalize();
@@ skipping 74 matching lines @@
   if (nItemIndex < 0) {
     if (CPWL_Wnd* pParent = GetParentWindow()) {
       ASSERT(pParent->GetClassName() == "CPWL_Note_Contents");
 
       CPWL_Note_Contents* pContents = (CPWL_Note_Contents*)pParent;
       nItemIndex = pContents->GetItemIndex(this);
     }
   }
 
   const CPWL_Note* pNote = GetNote();
-  ASSERT(pNote != NULL);
-
   CFX_WideString sSubject;
   sSubject.Format(pNote->GetReplyString().c_str(), nItemIndex);
 
   if (!m_sAuthor.IsEmpty()) {
     sSubject += L" - ";
     sSubject += m_sAuthor;
   }
   SetSubjectName(sSubject);
   RePosChildWnd();
 }
@@ skipping 144 matching lines @@
   return NULL;
 }
 
 FX_FLOAT CPWL_NoteItem::GetItemHeight(FX_FLOAT fLimitWidth) {
   if (fLimitWidth > 0) {
     if (!m_bSizeChanged)
       return m_fOldItemHeight;
 
     m_bSizeChanged = FALSE;
 
-    ASSERT(m_pSubject != NULL);
-    ASSERT(m_pDateTime != NULL);
-    ASSERT(m_pContents != NULL);
-
     FX_FLOAT fRet = m_pDateTime->GetContentRect().Height();
     FX_FLOAT fBorderWidth = (FX_FLOAT)GetBorderWidth();
     if (fLimitWidth > fBorderWidth * 2)
       fRet += m_pContents->GetContentsHeight(fLimitWidth - fBorderWidth * 2);
     fRet += POPUP_ITEM_HEAD_BOTTOM + POPUP_ITEM_BOTTOMWIDTH + fBorderWidth * 2;
 
     return m_fOldItemHeight = fRet;
   }
 
   return 0;
@@ skipping 207 matching lines @@
   RePosNoteChildren();
 }
 
 void CPWL_Note::RePosNoteChildren() {
   if (m_bResizing)
     return;
 
   m_bResizing = TRUE;
 
   if (IsValid()) {
-    ASSERT(m_pSubject != NULL);
-    ASSERT(m_pDateTime != NULL);
-    ASSERT(m_pContents != NULL);
-    ASSERT(m_pAuthor != NULL);
-    ASSERT(m_pCloseBox != NULL);
-    ASSERT(m_pIcon != NULL);
-    ASSERT(m_pLBBox != NULL);
-    ASSERT(m_pRBBox != NULL);
-    ASSERT(m_pContentsBar != NULL);
-    ASSERT(m_pOptions != NULL);
-
     CPDF_Rect rcClient = GetClientRect();
 
     CPDF_Rect rcIcon = rcClient;
     rcIcon.top -= 2.0f;
     rcIcon.right = rcIcon.left + 14.0f;
     rcIcon.bottom = rcIcon.top - 14.0f;
     rcIcon.Normalize();
     m_pIcon->Move(rcIcon, TRUE, FALSE);
     m_pIcon->SetVisible(CPWL_Utils::ContainsRect(rcClient, rcIcon));
 
@@ skipping 80 matching lines @@
     rcContentsBar.Normalize();
     m_pContentsBar->Move(rcContentsBar, TRUE, FALSE);
 
     m_rcCaption = rcClient;
     m_rcCaption.bottom = rcContents.top;
   }
 
   m_bResizing = FALSE;
 }
 
+// TODO(thestig): Make this return an enum.
 // 0-normal / 1-caption / 2-leftbottom corner / 3-rightbottom corner / 4-close /
 // 5-options
 int32_t CPWL_Note::NoteHitTest(const CPDF_Point& point) const {
-  ASSERT(m_pSubject != NULL);
-  ASSERT(m_pDateTime != NULL);
-  ASSERT(m_pContents != NULL);
-  ASSERT(m_pAuthor != NULL);
-  ASSERT(m_pIcon != NULL);
-  ASSERT(m_pContentsBar != NULL);
-
-  ASSERT(m_pCloseBox != NULL);
-  ASSERT(m_pLBBox != NULL);
-  ASSERT(m_pRBBox != NULL);
-  ASSERT(m_pOptions != NULL);
-
   GetClientRect();
 
   if (m_pSubject->WndHitTest(m_pSubject->ParentToChild(point)))
     return 1;
   if (m_pDateTime->WndHitTest(m_pDateTime->ParentToChild(point)))
     return 1;
   if (m_pAuthor->WndHitTest(m_pAuthor->ParentToChild(point)))
     return 1;
   if (m_pIcon->WndHitTest(m_pIcon->ParentToChild(point)))
     return 1;
@@ skipping 311 matching lines @@
   m_pContents->EnableRead(bEnabled);
 }
 
 CFX_WideString CPWL_Note::GetReplyString() const {
   return m_sReplyString;
 }
 
 void CPWL_Note::SetReplyString(const CFX_WideString& string) {
   m_sReplyString = string;
 }