Merge to XFA: Get rid of most instance of 'foo != NULL'

core/src/fxcrt/fx_basic_bstring.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <stddef.h>  // For offsetof().
 #include <cctype>
 
 #include "core/include/fxcrt/fx_basic.h"
@@ skipping 277 matching lines @@
   m_pData->m_String[nSrcLen] = 0;
 }
 void CFX_ByteString::CopyBeforeWrite() {
   if (m_pData == NULL || m_pData->m_nRefs <= 1) {
     return;
   }
   StringData* pData = m_pData;
   m_pData->Release();
   FX_STRSIZE nDataLength = pData->m_nDataLength;
   m_pData = StringData::Create(nDataLength);
-  if (m_pData != NULL) {
+  if (m_pData) {
     FXSYS_memcpy(m_pData->m_String, pData->m_String, nDataLength + 1);
   }
 }
 void CFX_ByteString::AllocBeforeWrite(FX_STRSIZE nLen) {
   if (m_pData && m_pData->m_nRefs <= 1 && m_pData->m_nAllocLength >= nLen) {
     return;
   }
   Empty();
   m_pData = StringData::Create(nLen);
 }
@@ skipping 382 matching lines @@
     nIndex = nNewLength;
   }
   nNewLength++;
   if (m_pData == NULL || m_pData->m_nAllocLength < nNewLength) {
     StringData* pOldData = m_pData;
     const FX_CHAR* pstr = m_pData->m_String;
     m_pData = StringData::Create(nNewLength);
     if (!m_pData) {
       return 0;
     }
-    if (pOldData != NULL) {
+    if (pOldData) {
       FXSYS_memmove(m_pData->m_String, pstr, (pOldData->m_nDataLength + 1));
       pOldData->Release();
     } else {
       m_pData->m_String[0] = 0;
     }
   }
   FXSYS_memmove(m_pData->m_String + nIndex + 1, m_pData->m_String + nIndex,
                 (nNewLength - nIndex));
   m_pData->m_String[nIndex] = ch;
   m_pData->m_nDataLength = nNewLength;
@@ skipping 375 matching lines @@
     fraction %= scale;
     scale /= 10;
   }
   return buf_size;
 }
 CFX_ByteString CFX_ByteString::FormatFloat(FX_FLOAT d, int precision) {
   FX_CHAR buf[32];
   FX_STRSIZE len = FX_ftoa(d, buf);
   return CFX_ByteString(buf, len);
 }