core/src/fxcrt/fx_xml_parser.cpp - Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_xml_parser.cpp

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_xml_parser.cpp

diff --git a/core/src/fxcrt/fx_xml_parser.cpp b/core/src/fxcrt/fx_xml_parser.cpp

index dcae0c58c070ebaafc7c1ace4586c1de50662369..56fbada3addddba93f4c7c3bab205b49acf4601c 100644

--- a/core/src/fxcrt/fx_xml_parser.cpp

+++ b/core/src/fxcrt/fx_xml_parser.cpp

@@ -819,7 +819,6 @@ int CXML_AttrMap::GetSize() const {

return m_pMap == NULL ? 0 : m_pMap->GetSize();

}

CXML_AttrItem& CXML_AttrMap::GetAt(int index) const {

- ASSERT(m_pMap != NULL);

return (*m_pMap)[index];

}

void CXML_AttrMap::RemoveAll() {