Merge to XFA: Get rid of most instance of 'foo != NULL'

fpdfsdk/src/pdfwindow/PWL_ListBox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/pdfwindow/PDFWindow.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h"
 #include "fpdfsdk/include/pdfwindow/PWL_EditCtrl.h"
 #include "fpdfsdk/include/pdfwindow/PWL_ListBox.h"
 #include "fpdfsdk/include/pdfwindow/PWL_ScrollBar.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Utils.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Wnd.h"
 
 #define IsFloatZero(f) ((f) < 0.0001 && (f) > -0.0001)
 #define IsFloatBigger(fa, fb) ((fa) > (fb) && !IsFloatZero((fa) - (fb)))
 #define IsFloatSmaller(fa, fb) ((fa) < (fb) && !IsFloatZero((fa) - (fb)))
 #define IsFloatEqual(fa, fb) IsFloatZero((fa) - (fb))
 
 /* ------------------------ CPWL_List_Notify ----------------------- */
 
 CPWL_List_Notify::CPWL_List_Notify(CPWL_ListBox* pList) : m_pList(pList) {
-  ASSERT(m_pList != NULL);
+  ASSERT(m_pList);
 }
 
 CPWL_List_Notify::~CPWL_List_Notify() {}
 
 void CPWL_List_Notify::IOnSetScrollInfoY(FX_FLOAT fPlateMin,
                                          FX_FLOAT fPlateMax,
                                          FX_FLOAT fContentMin,
                                          FX_FLOAT fContentMax,
                                          FX_FLOAT fSmallStep,
                                          FX_FLOAT fBigStep) {
@@ skipping 33 matching lines @@
 
 /* --------------------------- CPWL_ListBox ---------------------------- */
 
 CPWL_ListBox::CPWL_ListBox()
     : m_pList(NULL),
       m_pListNotify(NULL),
       m_bMouseDown(FALSE),
       m_bHoverSel(FALSE),
       m_pFillerNotify(NULL) {
   m_pList = IFX_List::NewList();
-
-  ASSERT(m_pList != NULL);
 }
 
 CPWL_ListBox::~CPWL_ListBox() {
   IFX_List::DelList(m_pList);
   delete m_pListNotify;
   m_pListNotify = NULL;
 }
 
 CFX_ByteString CPWL_ListBox::GetClassName() const {
   return "CPWL_ListBox";
@@ skipping 441 matching lines @@
   if (zDelta < 0) {
     m_pList->OnVK_DOWN(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
   } else {
     m_pList->OnVK_UP(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
   }
 
   FX_BOOL bExit = FALSE;
   OnNotifySelChanged(FALSE, bExit, nFlag);
   return TRUE;
 }