Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Side by Side Diff: fpdfsdk/src/pdfwindow/PWL_ListBox.cpp

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/pdfwindow/PDFWindow.h" 7 #include "fpdfsdk/include/pdfwindow/PDFWindow.h"
8 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h" 8 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h"
9 #include "fpdfsdk/include/pdfwindow/PWL_EditCtrl.h" 9 #include "fpdfsdk/include/pdfwindow/PWL_EditCtrl.h"
10 #include "fpdfsdk/include/pdfwindow/PWL_ListBox.h" 10 #include "fpdfsdk/include/pdfwindow/PWL_ListBox.h"
11 #include "fpdfsdk/include/pdfwindow/PWL_ScrollBar.h" 11 #include "fpdfsdk/include/pdfwindow/PWL_ScrollBar.h"
12 #include "fpdfsdk/include/pdfwindow/PWL_Utils.h" 12 #include "fpdfsdk/include/pdfwindow/PWL_Utils.h"
13 #include "fpdfsdk/include/pdfwindow/PWL_Wnd.h" 13 #include "fpdfsdk/include/pdfwindow/PWL_Wnd.h"
14 14
15 #define IsFloatZero(f) ((f) < 0.0001 && (f) > -0.0001) 15 #define IsFloatZero(f) ((f) < 0.0001 && (f) > -0.0001)
16 #define IsFloatBigger(fa, fb) ((fa) > (fb) && !IsFloatZero((fa) - (fb))) 16 #define IsFloatBigger(fa, fb) ((fa) > (fb) && !IsFloatZero((fa) - (fb)))
17 #define IsFloatSmaller(fa, fb) ((fa) < (fb) && !IsFloatZero((fa) - (fb))) 17 #define IsFloatSmaller(fa, fb) ((fa) < (fb) && !IsFloatZero((fa) - (fb)))
18 #define IsFloatEqual(fa, fb) IsFloatZero((fa) - (fb)) 18 #define IsFloatEqual(fa, fb) IsFloatZero((fa) - (fb))
19 19
20 /* ------------------------ CPWL_List_Notify ----------------------- */ 20 /* ------------------------ CPWL_List_Notify ----------------------- */
21 21
22 CPWL_List_Notify::CPWL_List_Notify(CPWL_ListBox* pList) : m_pList(pList) { 22 CPWL_List_Notify::CPWL_List_Notify(CPWL_ListBox* pList) : m_pList(pList) {
23 ASSERT(m_pList != NULL); 23 ASSERT(m_pList);
24 } 24 }
25 25
26 CPWL_List_Notify::~CPWL_List_Notify() {} 26 CPWL_List_Notify::~CPWL_List_Notify() {}
27 27
28 void CPWL_List_Notify::IOnSetScrollInfoY(FX_FLOAT fPlateMin, 28 void CPWL_List_Notify::IOnSetScrollInfoY(FX_FLOAT fPlateMin,
29 FX_FLOAT fPlateMax, 29 FX_FLOAT fPlateMax,
30 FX_FLOAT fContentMin, 30 FX_FLOAT fContentMin,
31 FX_FLOAT fContentMax, 31 FX_FLOAT fContentMax,
32 FX_FLOAT fSmallStep, 32 FX_FLOAT fSmallStep,
33 FX_FLOAT fBigStep) { 33 FX_FLOAT fBigStep) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 /* --------------------------- CPWL_ListBox ---------------------------- */ 68 /* --------------------------- CPWL_ListBox ---------------------------- */
69 69
70 CPWL_ListBox::CPWL_ListBox() 70 CPWL_ListBox::CPWL_ListBox()
71 : m_pList(NULL), 71 : m_pList(NULL),
72 m_pListNotify(NULL), 72 m_pListNotify(NULL),
73 m_bMouseDown(FALSE), 73 m_bMouseDown(FALSE),
74 m_bHoverSel(FALSE), 74 m_bHoverSel(FALSE),
75 m_pFillerNotify(NULL) { 75 m_pFillerNotify(NULL) {
76 m_pList = IFX_List::NewList(); 76 m_pList = IFX_List::NewList();
77
78 ASSERT(m_pList != NULL);
79 } 77 }
80 78
81 CPWL_ListBox::~CPWL_ListBox() { 79 CPWL_ListBox::~CPWL_ListBox() {
82 IFX_List::DelList(m_pList); 80 IFX_List::DelList(m_pList);
83 delete m_pListNotify; 81 delete m_pListNotify;
84 m_pListNotify = NULL; 82 m_pListNotify = NULL;
85 } 83 }
86 84
87 CFX_ByteString CPWL_ListBox::GetClassName() const { 85 CFX_ByteString CPWL_ListBox::GetClassName() const {
88 return "CPWL_ListBox"; 86 return "CPWL_ListBox";
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 if (zDelta < 0) { 528 if (zDelta < 0) {
531 m_pList->OnVK_DOWN(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag)); 529 m_pList->OnVK_DOWN(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
532 } else { 530 } else {
533 m_pList->OnVK_UP(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag)); 531 m_pList->OnVK_UP(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
534 } 532 }
535 533
536 FX_BOOL bExit = FALSE; 534 FX_BOOL bExit = FALSE;
537 OnNotifySelChanged(FALSE, bExit, nFlag); 535 OnNotifySelChanged(FALSE, bExit, nFlag);
538 return TRUE; 536 return TRUE;
539 } 537 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698