Clarify ordinary page handling.

Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=

Committed: https://crrev.com/988c6dbd265450c00e476fdb7b1240ae30dafcac
Cr-Commit-Position: refs/heads/master@{#367296}

[sof, 2016-01-02 20:06:53]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-02 20:07:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507633003/20001

[commit-bot: I haz the power, 2016-01-02 20:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 20:21:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-01-02 21:24:49]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-02 21:25:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507633003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507633003/40001

[commit-bot: I haz the power, 2016-01-02 23:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 23:02:24]

Dry run: This issue passed the CQ dry run.

[sof, 2016-01-03 07:34:32]

Description was changed from

==========
Clarify ordinary page handling.

R=
BUG=
==========

to

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=
BUG=
==========

[sof, 2016-01-03 07:37:19]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2016-01-03 07:37:19]

please take a look.

[haraken, 2016-01-03 15:43:19]

LGTM

https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/Page.cpp (right):

https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/Page.cpp:149:
ASSERT(!ordinaryPages().contains(this));

I'm curious why we can't enable the ASSERT in oilpan?

[sof, 2016-01-03 15:58:20]

https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/Page.cpp (right):

https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/Page.cpp:149:
ASSERT(!ordinaryPages().contains(this));
On 2016/01/03 15:43:19, haraken wrote:
> 
> I'm curious why we can't enable the ASSERT in oilpan?

It would be valid to test for it if LEAK_SANITIZER isn't in effect (=>
persistent singletons aren't released during shutdown.)

(I don't mind much either way, but the test coverage elsewhere wrt Oilpan's
handling of weak references, is pretty good by now.)

[haraken, 2016-01-03 16:36:32]

On 2016/01/03 15:58:20, sof wrote:
>
https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/page/Page.cpp (right):
> 
>
https://codereview.chromium.org/1507633003/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/page/Page.cpp:149:
> ASSERT(!ordinaryPages().contains(this));
> On 2016/01/03 15:43:19, haraken wrote:
> > 
> > I'm curious why we can't enable the ASSERT in oilpan?
> 
> It would be valid to test for it if LEAK_SANITIZER isn't in effect (=>
> persistent singletons aren't released during shutdown.)
> 
> (I don't mind much either way, but the test coverage elsewhere wrt Oilpan's
> handling of weak references, is pretty good by now.)

Thanks, makes sense.

[sof, 2016-01-04 06:29:23]

Description was changed from

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=
BUG=
==========

to

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=
==========

[sof, 2016-01-04 06:29:28]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-01-04 06:29:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507633003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507633003/60001

[commit-bot: I haz the power, 2016-01-04 06:34:24]

Description was changed from

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=
==========

to

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2016-01-04 06:34:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-04 06:35:31]

Description was changed from

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=
==========

to

==========
Clarify ordinary page handling.

Clarify that it is precise to use ordinaryPages() to locate storage
event targets (by StorageArea), along with generally tidying up Page
creation - "ordinary" ones as well as ones needed for internal purposes.

R=haraken
BUG=

Committed: https://crrev.com/988c6dbd265450c00e476fdb7b1240ae30dafcac
Cr-Commit-Position: refs/heads/master@{#367296}
==========

[commit-bot: I haz the power, 2016-01-04 06:35:31]

Patchset 4 (id:??) landed as
https://crrev.com/988c6dbd265450c00e476fdb7b1240ae30dafcac
Cr-Commit-Position: refs/heads/master@{#367296}