Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 1507633003: Clarify ordinary page handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whitespace Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FrameTree.cpp
diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp
index 7d7db09cceb3d621d9801a9320431c90995aca77..a4816ad06203d02d9e3da21a00efa598bef03ea6 100644
--- a/third_party/WebKit/Source/core/page/FrameTree.cpp
+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp
@@ -262,13 +262,12 @@ Frame* FrameTree::find(const AtomicString& name) const
// Search the entire tree of each of the other pages in this namespace.
// FIXME: Is random order OK?
- const WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<Page>>& pages = Page::ordinaryPages();
- for (const Page* otherPage : pages) {
- if (otherPage != page) {
- for (Frame* frame = otherPage->mainFrame(); frame; frame = frame->tree().traverseNext()) {
- if (frame->tree().name() == name)
- return frame;
- }
+ for (const Page* otherPage : Page::ordinaryPages()) {
+ if (otherPage == page)
+ continue;
+ for (Frame* frame = otherPage->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+ if (frame->tree().name() == name)
+ return frame;
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/Page.h » ('j') | third_party/WebKit/Source/core/page/Page.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698