Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1507633003: Clarify ordinary page handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whitespace Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 , m_elasticOverscroll(FloatSize()) 507 , m_elasticOverscroll(FloatSize())
508 , m_scheduler(Platform::current()->currentThread()->scheduler()->createWebVi ewScheduler(this).release()) 508 , m_scheduler(Platform::current()->currentThread()->scheduler()->createWebVi ewScheduler(this).release())
509 { 509 {
510 Page::PageClients pageClients; 510 Page::PageClients pageClients;
511 pageClients.chromeClient = m_chromeClientImpl.get(); 511 pageClients.chromeClient = m_chromeClientImpl.get();
512 pageClients.contextMenuClient = &m_contextMenuClientImpl; 512 pageClients.contextMenuClient = &m_contextMenuClientImpl;
513 pageClients.editorClient = &m_editorClientImpl; 513 pageClients.editorClient = &m_editorClientImpl;
514 pageClients.dragClient = &m_dragClientImpl; 514 pageClients.dragClient = &m_dragClientImpl;
515 pageClients.spellCheckerClient = &m_spellCheckerClientImpl; 515 pageClients.spellCheckerClient = &m_spellCheckerClientImpl;
516 516
517 m_page = adoptPtrWillBeNoop(new Page(pageClients)); 517 m_page = Page::createOrdinary(pageClients);
518 MediaKeysController::provideMediaKeysTo(*m_page, &m_mediaKeysClientImpl); 518 MediaKeysController::provideMediaKeysTo(*m_page, &m_mediaKeysClientImpl);
519 provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(cli ent ? client->speechRecognizer() : nullptr)); 519 provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(cli ent ? client->speechRecognizer() : nullptr));
520 provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create()); 520 provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());
521 provideDatabaseClientTo(*m_page, DatabaseClientImpl::create()); 521 provideDatabaseClientTo(*m_page, DatabaseClientImpl::create());
522 522
523 provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create()); 523 provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create());
524 m_page->setValidationMessageClient(ValidationMessageClientImpl::create(*this )); 524 m_page->setValidationMessageClient(ValidationMessageClientImpl::create(*this ));
525 provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProvi derImpl::create()); 525 provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProvi derImpl::create());
526 StorageNamespaceController::provideStorageNamespaceTo(*m_page, &m_storageCli entImpl); 526 StorageNamespaceController::provideStorageNamespaceTo(*m_page, &m_storageCli entImpl);
527 527
528 m_page->makeOrdinary();
529
530 if (m_client) { 528 if (m_client) {
531 setVisibilityState(m_client->visibilityState(), true); 529 setVisibilityState(m_client->visibilityState(), true);
532 } 530 }
533 531
534 initializeLayerTreeView(); 532 initializeLayerTreeView();
535 533
536 m_devToolsEmulator = DevToolsEmulator::create(this); 534 m_devToolsEmulator = DevToolsEmulator::create(this);
537 535
538 allInstances().add(this); 536 allInstances().add(this);
539 537
(...skipping 4090 matching lines...) Expand 10 before | Expand all | Expand 10 after
4630 void WebViewImpl::detachPaintArtifactCompositor() 4628 void WebViewImpl::detachPaintArtifactCompositor()
4631 { 4629 {
4632 if (!m_layerTreeView) 4630 if (!m_layerTreeView)
4633 return; 4631 return;
4634 4632
4635 m_layerTreeView->setDeferCommits(true); 4633 m_layerTreeView->setDeferCommits(true);
4636 m_layerTreeView->clearRootLayer(); 4634 m_layerTreeView->clearRootLayer();
4637 } 4635 }
4638 4636
4639 } // namespace blink 4637 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698