third_party/WebKit/Source/core/testing/DummyPageHolder.cpp - Issue 1507633003: Clarify ordinary page handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

Issue 1507633003: Clarify ordinary page handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whitespace Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

diff --git a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

index aa1e1d5620e856e54042f16f7fca1c74f919d0f8..9a6696d9f19bb6e56a18f89af168c73c467582ae 100644

--- a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

+++ b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

@@ -68,7 +68,7 @@ DummyPageHolder::DummyPageHolder(

pageClients.dragClient = pageClientsArgument->dragClient;

pageClients.spellCheckerClient = pageClientsArgument->spellCheckerClient;

}

- m_page = adoptPtrWillBeNoop(new Page(pageClients));

+ m_page = Page::create(pageClients);

Settings& settings = m_page->settings();

// FIXME: http://crbug.com/363843. This needs to find a better way to

// not create graphics layers.