Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1507633003: Clarify ordinary page handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whitespace Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 2ded59edf80859830c9e575e2a056d606ccd99fe..a065625d29b56664f5375395cb8a50397552bcee 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -514,7 +514,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
pageClients.dragClient = &m_dragClientImpl;
pageClients.spellCheckerClient = &m_spellCheckerClientImpl;
- m_page = adoptPtrWillBeNoop(new Page(pageClients));
+ m_page = Page::createOrdinary(pageClients);
MediaKeysController::provideMediaKeysTo(*m_page, &m_mediaKeysClientImpl);
provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(client ? client->speechRecognizer() : nullptr));
provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());
@@ -525,8 +525,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProviderImpl::create());
StorageNamespaceController::provideStorageNamespaceTo(*m_page, &m_storageClientImpl);
- m_page->makeOrdinary();
-
if (m_client) {
setVisibilityState(m_client->visibilityState(), true);
}

Powered by Google App Engine
This is Rietveld 408576698