Clarify ordinary page handling.

third_party/WebKit/Source/modules/storage/StorageArea.cpp

 /*
  * Copyright (C) 2009 Google Inc. All Rights Reserved.
  *           (C) 2008 Apple Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 143 matching lines @@
     return result;
 }
 
 size_t StorageArea::memoryBytesUsedByCache()
 {
     return m_storageArea->memoryBytesUsedByCache();
 }
 
 void StorageArea::dispatchLocalStorageEvent(const String& key, const String& oldValue, const String& newValue, SecurityOrigin* securityOrigin, const KURL& pageURL, WebStorageArea* sourceAreaInstance, bool originatedInProcess)
 {
-    // FIXME: This looks suspicious. Why doesn't this use allPages instead?
-    const WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<Page>>& pages = Page::ordinaryPages();
-    for (Page* page : pages) {
+    // Iterate over all pages that have a StorageNamespaceController supplement.
+    for (Page* page : Page::ordinaryPages()) {
         for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
             // FIXME: We do not yet have a way to dispatch events to out-of-process frames.
             if (!frame->isLocalFrame())
                 continue;
             LocalFrame* localFrame = toLocalFrame(frame);
             LocalDOMWindow* localWindow = localFrame->localDOMWindow();
             Storage* storage = DOMWindowStorage::from(*localWindow).optionalLocalStorage();
             if (storage && localFrame->document()->securityOrigin()->canAccess(securityOrigin) && !isEventSource(storage, sourceAreaInstance))
                 localFrame->localDOMWindow()->enqueueWindowEvent(StorageEvent::create(EventTypeNames::storage, key, oldValue, newValue, pageURL, storage));
         }
         if (InspectorDOMStorageAgent* agent = StorageNamespaceController::from(page)->inspectorAgent())
             agent->didDispatchDOMStorageEvent(key, oldValue, newValue, LocalStorage, securityOrigin);
     }
 }
 
 static Page* findPageWithSessionStorageNamespace(const WebStorageNamespace& sessionNamespace)
 {
-    // FIXME: This looks suspicious. Why doesn't this use allPages instead?
-    const WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<Page>>& pages = Page::ordinaryPages();
-    for (Page* page : pages) {
+    // Iterate over all pages that have a StorageNamespaceController supplement.
+    for (Page* page : Page::ordinaryPages()) {
         const bool dontCreateIfMissing = false;
         StorageNamespace* storageNamespace = StorageNamespaceController::from(page)->sessionStorage(dontCreateIfMissing);
         if (storageNamespace && storageNamespace->isSameNamespace(sessionNamespace))
             return page;
     }
     return nullptr;
 }
 
 void StorageArea::dispatchSessionStorageEvent(const String& key, const String& oldValue, const String& newValue, SecurityOrigin* securityOrigin, const KURL& pageURL, const WebStorageNamespace& sessionNamespace, WebStorageArea* sourceAreaInstance, bool originatedInProcess)
 {
@@ skipping 16 matching lines @@
 }
 
 bool StorageArea::isEventSource(Storage* storage, WebStorageArea* sourceAreaInstance)
 {
     ASSERT(storage);
     StorageArea* area = storage->area();
     return area->m_storageArea == sourceAreaInstance;
 }
 
 } // namespace blink