third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 1507633003: Clarify ordinary page handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1507633003: Clarify ordinary page handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whitespace Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 71931577455e50b5585c09fe80b1fd1c09e067a8..055c78e69698bdc9bf36bd1a6c8c0fc90b231646 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -245,7 +245,7 @@ bool WebPagePopupImpl::initializePage()

m_chromeClient = PagePopupChromeClient::create(this);

pageClients.chromeClient = m_chromeClient.get();

- m_page = adoptPtrWillBeNoop(new Page(pageClients));

+ m_page = Page::create(pageClients);

m_page->settings().setScriptEnabled(true);

m_page->settings().setAllowScriptsToCloseWindows(true);

m_page->settings().setDeviceSupportsTouch(m_webView->page()->settings().deviceSupportsTouch());