Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1500393002: Always use high precision on NDS transform (Closed)

Created:
5 years ago by Joel.Liang
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Always use high precision on NDS transform To fix the Chrome fillRect issue on Galaxy S6. We should use high precision for position related calculation. BUG=chromium:552999 Committed: https://skia.googlesource.com/skia/+/8e03b8af752638ee7375460f03aebd554360486f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLVertexShaderBuilder.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500393002/1
5 years ago (2015-12-07 03:43:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-07 03:43:30 UTC) #5
Joel.Liang
Hi Brian, I have changed the code to use high precision for NDS transform. Please ...
5 years ago (2015-12-07 03:53:10 UTC) #9
bsalomon
lgtm
5 years ago (2015-12-07 18:32:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500393002/1
5 years ago (2015-12-07 18:32:22 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-07 18:33:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e03b8af752638ee7375460f03aebd554360486f

Powered by Google App Engine
This is Rietveld 408576698