Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code in some attributeChanged overrides to parseAttribute. This CL simplifies the code. This CL has no behavior changes. BUG=561251 Committed: https://crrev.com/3f54f280a62b44991630573155310c2006d2c6c5 Cr-Commit-Position: refs/heads/master@{#362912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -72 lines) Patch
M third_party/WebKit/Source/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.cpp View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
kochi@, would you review this please?
5 years ago (2015-12-03 03:25:07 UTC) #2
kochi
lgtm
5 years ago (2015-12-03 03:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496773002/1
5 years ago (2015-12-03 04:06:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 05:13:32 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 05:14:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3f54f280a62b44991630573155310c2006d2c6c5
Cr-Commit-Position: refs/heads/master@{#362912}

Powered by Google App Engine
This is Rietveld 408576698