Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
index 284ea311990279688eb16b6044f746297e9b3da4..ee77275db31463329e9482e1748333c3f106a658 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
@@ -508,6 +508,7 @@ void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicStri
KURL actionURL = document().completeURL(m_attributes.action().isEmpty() ? document().url().string() : m_attributes.action());
if (MixedContentChecker::isMixedFormAction(document().frame(), actionURL))
UseCounter::count(document().frame(), UseCounter::MixedContentFormPresent);
+ logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "form", actionAttr.toString(), oldValue, value);
} else if (name == targetAttr) {
m_attributes.setTarget(value);
} else if (name == methodAttr) {
@@ -525,13 +526,6 @@ void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicStri
}
}
-void HTMLFormElement::attributeChanged(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason reason)
-{
- if (name == actionAttr)
- logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "form", actionAttr.toString(), oldValue, newValue);
- HTMLElement::attributeChanged(name, oldValue, newValue, reason);
-}
-
void HTMLFormElement::associate(FormAssociatedElement& e)
{
m_associatedElementsAreDirty = true;
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.h ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698