third_party/WebKit/Source/core/html/HTMLLinkElement.h - Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.h

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLLabelElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLLinkElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.h b/third_party/WebKit/Source/core/html/HTMLLinkElement.h

index f499d544d7a2cb476ad2488f35fe0521d241e35d..42d102b5dbec30ff92a1b0305b3aebef902d3542 100644

--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.h

@@ -184,9 +184,6 @@ public:

private:

HTMLLinkElement(Document&, bool createdByParser);

- void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason) override;

- void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

LinkStyle* linkStyle() const;

LinkImport* linkImport() const;

LinkResource* linkResourceToProcess();

@@ -195,6 +192,7 @@ private:

static void processCallback(Node*);

// From Node and subclassses

+ void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

InsertionNotificationRequest insertedInto(ContainerNode*) override;

void removedFrom(ContainerNode*) override;

bool isURLAttribute(const Attribute&) const override;