Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
index 26a7e67072f714371a866ec0b899f0fe282260f1..5f8f096e714060717ee86c5c9c1ae68038e8f905 100644
--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
@@ -176,13 +176,6 @@ void HTMLAnchorElement::setActive(bool down)
ContainerNode::setActive(down);
}
-void HTMLAnchorElement::attributeChanged(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason reason)
-{
- if (name == hrefAttr)
- logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "a", hrefAttr.toString(), oldValue, newValue);
- HTMLElement::attributeChanged(name, oldValue, newValue, reason);
-}
-
void HTMLAnchorElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
{
if (name == hrefAttr) {
@@ -206,6 +199,7 @@ void HTMLAnchorElement::parseAttribute(const QualifiedName& name, const AtomicSt
}
}
invalidateCachedVisitedLinkHash();
+ logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "a", hrefAttr.toString(), oldValue, value);
} else if (name == nameAttr || name == titleAttr) {
// Do nothing.
} else if (name == relAttr) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.h ('k') | third_party/WebKit/Source/core/html/HTMLButtonElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698