third_party/WebKit/Source/core/html/HTMLButtonElement.h - Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.h

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLButtonElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.h b/third_party/WebKit/Source/core/html/HTMLButtonElement.h

index ef9cee6ff0d0e8b63ac3f2f4247d36845a1c369e..ffc3df03204469cbaf6df00583e191b9c2195802 100644

--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.h

@@ -52,7 +52,6 @@ private:

bool alwaysCreateUserAgentShadowRoot() const override { return false; }

Node::InsertionNotificationRequest insertedInto(ContainerNode*) override;

- void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason) override;

void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

bool isPresentationAttribute(const QualifiedName&) const override;

void defaultEventHandler(Event*) override;