Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
index 0ee295bef4c1701b21233454fc538b7d5eddaf1f..0d81d0ed6422a3c6ec83ab2d277a91f6f8831b05 100644
--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
@@ -103,6 +103,8 @@ void HTMLButtonElement::parseAttribute(const QualifiedName& name, const AtomicSt
m_type = SUBMIT;
setNeedsWillValidateCheck();
} else {
+ if (name == formactionAttr)
+ logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "button", formactionAttr.toString(), oldValue, value);
HTMLFormControlElement::parseAttribute(name, oldValue, value);
}
}
@@ -218,11 +220,4 @@ Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode
return request;
}
-void HTMLButtonElement::attributeChanged(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason reason)
-{
- if (name == formactionAttr)
- logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "button", formactionAttr.toString(), oldValue, newValue);
- HTMLFormControlElement::attributeChanged(name, oldValue, newValue, reason);
-}
-
} // namespace
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLButtonElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698