Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1496773002: Move code in some attributeChanged overrides to parseAttribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index d42aea57f386b0f17db9d90b5479166a499df086..b2ee9ac98748c35c7ae48ef41a8777ede5b7672c 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -666,13 +666,6 @@ void HTMLInputElement::collectStyleForPresentationAttribute(const QualifiedName&
}
}
-void HTMLInputElement::attributeChanged(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason reason)
-{
- if (name == formactionAttr)
- logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "input", formactionAttr.toString(), oldValue, newValue);
- HTMLTextFormControlElement::attributeChanged(name, oldValue, newValue, reason);
-}
-
void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
{
ASSERT(m_inputType);
@@ -782,6 +775,8 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr
HTMLTextFormControlElement::parseAttribute(name, oldValue, value);
UseCounter::count(document(), UseCounter::PrefixedDirectoryAttribute);
} else {
+ if (name == formactionAttr)
+ logEventIfIsolatedWorldAndInDocument("blinkSetAttribute", "input", formactionAttr.toString(), oldValue, value);
HTMLTextFormControlElement::parseAttribute(name, oldValue, value);
}
m_inputTypeView->attributeChanged();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | third_party/WebKit/Source/core/html/HTMLLabelElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698