Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD…

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed)

Created:
7 years, 7 months ago by titzer

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintDataTo for HInstruction BUG= Committed: https://code.google.com/p/v8/source/detail?r=14710

Patch Set 2 : Turn late dead code elimination back on. #

Total comments: 9

Patch Set 3 : Integrate feedback from code review. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -33 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-seqstrsetchar-ex1.js	View	1 2	1 chunk	+26 lines, -12 lines	0 comments	Download
A +	test/mjsunit/regress/regress-seqstrsetchar-ex2.js	View	1 2	1 chunk	+5 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://codereview.chromium.org/14895019/diff/2001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14895019/diff/2001/src/hydrogen-instructions.cc#newcode812 src/hydrogen-instructions.cc:812: HValue *value = OperandAt(i); nit: "HValue* ...

7 years, 7 months ago (2013-05-16 13:18:57 UTC) #2

titzer

Committed patchset #3 manually as r14710 (presubmit successful).

7 years, 7 months ago (2013-05-16 14:27:49 UTC) #3

titzer

7 years, 7 months ago (2013-05-16 14:28:44 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14895019/diff/2001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/14895019/diff/2001/src/hydrogen-instructions....
src/hydrogen-instructions.cc:812: HValue *value = OperandAt(i);
On 2013/05/16 13:18:57, Jakob wrote:
> nit: "HValue* value"
> 
> ...or just "OperandAt(i)->PrintNameTo(stream);"

Done.

https://codereview.chromium.org/14895019/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/14895019/diff/2001/src/hydrogen.cc#newcode5442
src/hydrogen.cc:5442: void HGraph::MarkLive(HValue *ref, HValue* instr,
On 2013/05/16 13:18:57, Jakob wrote:
> nit: while you're here: "HValue* ref", and if all parameters in a
> method/function declaration/definition don't fit on one line, they each get
> their own, as in:
> void HGraph::MarkLive(HValue* ref,
>                       HValue* instr,
>                       ZoneList<HValue*>* worklist) {

Fits :)

https://codereview.chromium.org/14895019/diff/2001/src/hydrogen.cc#newcode5451
src/hydrogen.cc:5451: ALLOW_HANDLE_DEREF(isolate(), "debug mode printing");
On 2013/05/16 13:18:57, Jakob wrote:
> I don't see any handle being dereferenced?

Yeah, it can happen if you try to print an instruction which is a HConstant of a
map.

https://codereview.chromium.org/14895019/diff/2001/test/mjsunit/regress/regre...
File test/mjsunit/regress/regress-seqstrsetchar-ex1.js (right):

https://codereview.chromium.org/14895019/diff/2001/test/mjsunit/regress/regre...
test/mjsunit/regress/regress-seqstrsetchar-ex1.js:32: return 311;
On 2013/05/16 13:18:57, Jakob wrote:
> nit: indentation

Done.

Expand Messages | Collapse Messages