Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/regress/regress-seqstrsetchar-ex1.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1692 LOperand* object = UseFixed(instr->value(), a0); 1692 LOperand* object = UseFixed(instr->value(), a0);
1693 LDateField* result = 1693 LDateField* result =
1694 new(zone()) LDateField(object, FixedTemp(a1), instr->index()); 1694 new(zone()) LDateField(object, FixedTemp(a1), instr->index());
1695 return MarkAsCall(DefineFixed(result, v0), instr, CAN_DEOPTIMIZE_EAGERLY); 1695 return MarkAsCall(DefineFixed(result, v0), instr, CAN_DEOPTIMIZE_EAGERLY);
1696 } 1696 }
1697 1697
1698 1698
1699 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1699 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1700 LOperand* string = UseRegister(instr->string()); 1700 LOperand* string = UseRegister(instr->string());
1701 LOperand* index = UseRegister(instr->index()); 1701 LOperand* index = UseRegister(instr->index());
1702 LOperand* value = UseRegister(instr->value()); 1702 LOperand* value = UseTempRegister(instr->value());
1703 LSeqStringSetChar* result = 1703 LSeqStringSetChar* result =
1704 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value); 1704 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1705 return DefineAsRegister(result); 1705 return DefineAsRegister(result);
1706 } 1706 }
1707 1707
1708 1708
1709 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) { 1709 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) {
1710 return NULL; 1710 return NULL;
1711 } 1711 }
1712 1712
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
2483 2483
2484 2484
2485 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2485 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2486 LOperand* object = UseRegister(instr->object()); 2486 LOperand* object = UseRegister(instr->object());
2487 LOperand* index = UseRegister(instr->index()); 2487 LOperand* index = UseRegister(instr->index());
2488 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2488 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2489 } 2489 }
2490 2490
2491 2491
2492 } } // namespace v8::internal 2492 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/regress/regress-seqstrsetchar-ex1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698