Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: src/hydrogen-instructions.h

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 DISALLOW_COPY_AND_ASSIGN(HValue); 1244 DISALLOW_COPY_AND_ASSIGN(HValue);
1245 }; 1245 };
1246 1246
1247 1247
1248 class HInstruction: public HValue { 1248 class HInstruction: public HValue {
1249 public: 1249 public:
1250 HInstruction* next() const { return next_; } 1250 HInstruction* next() const { return next_; }
1251 HInstruction* previous() const { return previous_; } 1251 HInstruction* previous() const { return previous_; }
1252 1252
1253 virtual void PrintTo(StringStream* stream); 1253 virtual void PrintTo(StringStream* stream);
1254 virtual void PrintDataTo(StringStream* stream) { } 1254 virtual void PrintDataTo(StringStream* stream);
1255 1255
1256 bool IsLinked() const { return block() != NULL; } 1256 bool IsLinked() const { return block() != NULL; }
1257 void Unlink(); 1257 void Unlink();
1258 void InsertBefore(HInstruction* next); 1258 void InsertBefore(HInstruction* next);
1259 void InsertAfter(HInstruction* previous); 1259 void InsertAfter(HInstruction* previous);
1260 1260
1261 // The position is a write-once variable. 1261 // The position is a write-once variable.
1262 int position() const { return position_; } 1262 int position() const { return position_; }
1263 bool has_position() const { return position_ != RelocInfo::kNoPosition; } 1263 bool has_position() const { return position_ != RelocInfo::kNoPosition; }
1264 void set_position(int position) { 1264 void set_position(int position) {
(...skipping 5196 matching lines...) Expand 10 before | Expand all | Expand 10 after
6461 virtual bool IsDeletable() const { return true; } 6461 virtual bool IsDeletable() const { return true; }
6462 }; 6462 };
6463 6463
6464 6464
6465 #undef DECLARE_INSTRUCTION 6465 #undef DECLARE_INSTRUCTION
6466 #undef DECLARE_CONCRETE_INSTRUCTION 6466 #undef DECLARE_CONCRETE_INSTRUCTION
6467 6467
6468 } } // namespace v8::internal 6468 } } // namespace v8::internal
6469 6469
6470 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6470 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698