Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: src/hydrogen.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 939a5fac809954542b5a76c0ffda3df93f9bf669..feff6f9bdf9d5bc7ea315df02814f9af78ee7f68 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5439,8 +5439,7 @@ void HGraph::MarkLiveInstructions() {
}
-void HGraph::MarkLive(HValue *ref, HValue* instr,
- ZoneList<HValue*>* worklist) {
+void HGraph::MarkLive(HValue* ref, HValue* instr, ZoneList<HValue*>* worklist) {
if (!instr->CheckFlag(HValue::kIsLive)) {
instr->SetFlag(HValue::kIsLive);
worklist->Add(instr, zone());
@@ -5448,6 +5447,7 @@ void HGraph::MarkLive(HValue *ref, HValue* instr,
if (FLAG_trace_dead_code_elimination) {
HeapStringAllocator allocator;
StringStream stream(&allocator);
+ ALLOW_HANDLE_DEREF(isolate(), "debug mode printing");
if (ref != NULL) {
ref->PrintTo(&stream);
} else {
@@ -10329,7 +10329,7 @@ bool HOptimizedGraphBuilder::MatchRotateRight(HValue* left,
}
-bool CanBeZero(HValue *right) {
+bool CanBeZero(HValue* right) {
if (right->IsConstant()) {
HConstant* right_const = HConstant::cast(right);
if (right_const->HasInteger32Value() &&
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698