Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1808 matching lines...) Expand 10 before | Expand all | Expand 10 after
1819 LOperand* object = UseFixed(instr->value(), r0); 1819 LOperand* object = UseFixed(instr->value(), r0);
1820 LDateField* result = 1820 LDateField* result =
1821 new(zone()) LDateField(object, FixedTemp(r1), instr->index()); 1821 new(zone()) LDateField(object, FixedTemp(r1), instr->index());
1822 return MarkAsCall(DefineFixed(result, r0), instr, CAN_DEOPTIMIZE_EAGERLY); 1822 return MarkAsCall(DefineFixed(result, r0), instr, CAN_DEOPTIMIZE_EAGERLY);
1823 } 1823 }
1824 1824
1825 1825
1826 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1826 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1827 LOperand* string = UseRegister(instr->string()); 1827 LOperand* string = UseRegister(instr->string());
1828 LOperand* index = UseRegister(instr->index()); 1828 LOperand* index = UseRegister(instr->index());
1829 LOperand* value = UseRegister(instr->value()); 1829 LOperand* value = UseTempRegister(instr->value());
1830 LSeqStringSetChar* result = 1830 LSeqStringSetChar* result =
1831 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value); 1831 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1832 return DefineAsRegister(result); 1832 return DefineAsRegister(result);
1833 } 1833 }
1834 1834
1835 1835
1836 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) { 1836 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) {
1837 return NULL; 1837 return NULL;
1838 } 1838 }
1839 1839
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
2608 2608
2609 2609
2610 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2610 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2611 LOperand* object = UseRegister(instr->object()); 2611 LOperand* object = UseRegister(instr->object());
2612 LOperand* index = UseRegister(instr->index()); 2612 LOperand* index = UseRegister(instr->index());
2613 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2613 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2614 } 2614 }
2615 2615
2616 2616
2617 } } // namespace v8::internal 2617 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698